From: "Clément Lassieur" <clement@lassieur.org>
To: Alexandre Hannud Abdo <abdo@member.fsf.org>
Cc: 68414@debbugs.gnu.org
Subject: [bug#68414] [PATCH] doc: Improve documentation for submitting patches
Date: Mon, 15 Jan 2024 19:12:48 +0100 [thread overview]
Message-ID: <87il3usbxb.fsf@lassieur.org> (raw)
In-Reply-To: <984db445-6323-ec95-ec2c-da4a3915e814@member.fsf.org> (Alexandre Hannud Abdo's message of "Mon, 15 Jan 2024 15:27:23 +0100")
Hello Alexandre,
On Mon, Jan 15 2024, Alexandre Hannud Abdo wrote:
> Ni! Thank you, we're actually in good agreement.
>
> The possibility of sending inline patches is already there in the current documentation. The excerpt you cite is mostly collage of existing text that was spread in different sections.
>
> I sought to articulate the possibilities and their preferred order more
> clearly so people can better weight the consequences. And I actually tried to
> word it in a way that would discourage inline patches more strongly than the
> current text. I have sent inline patches in the past, after reading the
> current text, and I'm sure I would not have sent them with the text I propose.
The new version goes like: "You may also...". But the truth is: "you
must not." (because inline patches just don't work without git
send-email). It's a bit harsh, so I believe the best is to avoid
talking about things that we don't want.
> The only thing is that I did not feel authorized to exclude a possibility when
> rewriting the doc. But if you tell me I can, I'll happily change the wording
> to strictly discourage sending inline patches with an email client.
Rather than discourage, I think it's fine to not talk about it. We
don't need to add rules for each use case.
Thanks,
Clément
next prev parent reply other threads:[~2024-01-15 18:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-13 5:08 [bug#68414] [PATCH] doc: Improve documentation for submitting patches Ale Abdo
2024-01-13 11:27 ` Clément Lassieur
2024-01-15 14:27 ` Alexandre Hannud Abdo
2024-01-15 18:12 ` Clément Lassieur [this message]
2024-01-16 17:45 ` Alexandre Hannud Abdo
2024-02-21 22:05 ` [bug#68414] [PATCH v1] " Ale Abdo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il3usbxb.fsf@lassieur.org \
--to=clement@lassieur.org \
--cc=68414@debbugs.gnu.org \
--cc=abdo@member.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.