From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id oIsyEHPsSGYnFAAAqHPOHw:P1 (envelope-from ) for ; Sat, 18 May 2024 19:59:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id oIsyEHPsSGYnFAAAqHPOHw (envelope-from ) for ; Sat, 18 May 2024 19:59:15 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1716055155; a=rsa-sha256; cv=none; b=JVb9RKzorq6UZRtv/qPy10u1rp6wPx6IvdNkJUW2Wzzz+XPvYrybuanU+QXCGZRomVt2Id d3DortVjuRCHQe2DvrGHX2QPTxPPAqCEI6A/NC5LhWE9Gu2ggk0EY8t4ootUVejgAc7H5n 6ZDXwAi5fLLcJ2uful/isM8gYqPJrCcsvovh1+0b38U9CvR1keuGFMAiqFQu7i4tSlG/1j m7t0fggnCr1zOAlzWVc0ZjdCU+LijPjMk4oJRaWqRpxZxTb+nCcJuuD+Cv5vQrcN1lqjvG CvRPS095JihTDdhlU3DBFneyD001wCF2nYnGZGyxxF7SPTDYWpxAoTGpJj3ZjQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1716055155; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=Pgwu/voyv7waz1a/ZAezTEXxcf2cXJKF9s9OJ5TkxM0=; b=C12+foYMgCuaMN7xtuxJWq7J1Tvq6WgZa8vPXDq59zWuwY5wipN00NsKJ2/+W9ooaVfpgG RVVjnukdfBmLs35YoCawBXn88kThsQgX+sitB+nFVVxuA7vwvEICZq40dNgHTSgYZMKqYv fVwlEzzLB2qnkKw6wCf6SaNdB4s12xknxvwqEOJdT/lERDfWlrm015uPJKaftnshJnEKjw 4lJeFk/bPcsIxpJdwJT4URPwLx8aYx2qgtTqfBf+1I04ZpsyDuWWNmdXSUxeDZJcpaN3bU ccsac+aG3Y9/GxLFg8L3+r8yv/C9wUiE3AoFL98owq34ymeYviWvy3SDC1+njQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EF12E30347 for ; Sat, 18 May 2024 19:59:14 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s8OKl-0000n8-Nh; Sat, 18 May 2024 13:59:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s8OKg-0000mg-ML for guix-patches@gnu.org; Sat, 18 May 2024 13:58:58 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s8OKg-00087b-EF for guix-patches@gnu.org; Sat, 18 May 2024 13:58:58 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s8OKj-0005ur-VE for guix-patches@gnu.org; Sat, 18 May 2024 13:59:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70892] [PATCH 4/6] gnu: Add u-boot-starfive-visionfive2. Resent-From: Zheng Junjie Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 18 May 2024 17:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70892 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vagrant Cascadian Cc: 70892@debbugs.gnu.org, Efraim Flashner Received: via spool by 70892-submit@debbugs.gnu.org id=B70892.171605513122708 (code B ref 70892); Sat, 18 May 2024 17:59:01 +0000 Received: (at 70892) by debbugs.gnu.org; 18 May 2024 17:58:51 +0000 Received: from localhost ([127.0.0.1]:34780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s8OKW-0005u5-LE for submit@debbugs.gnu.org; Sat, 18 May 2024 13:58:50 -0400 Received: from smtp81.cstnet.cn ([159.226.251.81]:50746 helo=cstnet.cn) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s8OKJ-0005tB-Le for 70892@debbugs.gnu.org; Sat, 18 May 2024 13:58:46 -0400 Received: from m (unknown [183.247.5.112]) by APP-03 (Coremail) with SMTP id rQCowADn7ZE57Ehmi+LQCw--.12453S2; Sun, 19 May 2024 01:58:19 +0800 (CST) From: Zheng Junjie In-Reply-To: <87o797rm6y.fsf@wireframe> (Vagrant Cascadian's message of "Wed, 15 May 2024 10:59:01 -0700") References: <7c3b72a45a1c5d6adfb6ccd586ab68d587cfc420.1715508730.git.zhengjunjie@iscas.ac.cn> <87o797rm6y.fsf@wireframe> User-Agent: mu4e 1.12.4; emacs 30.0.50 Date: Sun, 19 May 2024 01:58:17 +0800 Message-ID: <87ikzbknnq.fsf@iscas.ac.cn> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-CM-TRANSID: rQCowADn7ZE57Ehmi+LQCw--.12453S2 X-Coremail-Antispam: 1UD129KBjvJXoW7KF43Aw1DZr1xuFWrZF45Awb_yoW8ZrW7pF W7uF18Ww4kKFWfJwsFgFWjkw4rGw4rtFW5Kw4kXryjvw4rCFyxXr9aqan8ZFnxW3WfJ3W2 vay8trW5AFWkZaDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUk0b7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4 A2jsIEc7CjxVAFwI0_Gr0_Gr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21le4C267I2x7xF 54xIwI1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I 8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41l42xK82IY c2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s 026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1Y6r17MIIYrxkI7VAKI48JMIIF 0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0x vE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv 6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUq_b1DUUUU X-Originating-IP: [183.247.5.112] X-CM-SenderInfo: x2kh0wxmxqyx3h6l2u1dvotugofq/ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: EF12E30347 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -7.96 X-Spam-Score: -7.96 X-TUID: ru/s1VH4fQy9 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Vagrant Cascadian writes: > On 2024-05-12, Zheng Junjie wrote: >> diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm >> index cfe8046731..1d52e961fd 100644 >> --- a/gnu/packages/bootloaders.scm >> +++ b/gnu/packages/bootloaders.scm > ... >> @@ -1343,6 +1344,36 @@ (define-public u-boot-sifive-unmatched >> (modify-inputs (package-inputs base) >> (append opensbi-generic)))))) >>=20=20 >> +(define-public u-boot-starfive-visionfive2 >> + (let ((opensbi (package >> + (inherit opensbi-generic) >> + (arguments >> + (substitute-keyword-arguments >> + (package-arguments opensbi-generic) >> + ((#:make-flags flags) >> + `(cons* "FW_TEXT_START=3D0x40000000" >> + "FW_OPTIONS=3D0" >> + ,flags)))))) >> + (base (make-u-boot-package "starfive_visionfive2" "riscv64-linu= x-gnu"))) > > I would not want to block this patch on this, but... > > Curious about the advantages and disadvantages of making this an > on-the-fly opensbi package variant... as so far I think most u-boot > packages just pull in inputs of other packages > (e.g. arm-trusted-firmware-*) rather than modifying them as part of the > u-boot-* package. As far as I know, the opensbi support in visionfive2 was added later, so the opensbi configuration needs to be modified, and later other boards should be able to use the generic version of opensbi. > > If this seems to be a good approach overall, maybe we should switch more > packages to use this approach ... or if there are significant downsides, > perhaps this patch series should just create another opensbi variant and > add it to inputs or whatever? The disadvantage of this is that cuirass can't see on-the-fly opensbi, and if the hidden input takes a long time to compile, it will affect the compilation time of the package. So I split opensbi-for-visionfive2 in the v2 patchset. > > Thoughts? > > > That aside, looks good to me. :) > > Thanks! > > live well, > vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfr6klGDOXiwIdX/bO1qpk+Gi3/AFAmZI7DkACgkQO1qpk+Gi 3/Afrw/+KQULiCoqXoVGEu239i2ymDUEqj63ASXSqA3litQQBNIvC8jbsnqBfOtX jeefRNx8NkMFAiu9wXbKDh7v9NtgzWd1A7NL0s8ZmAm2584pa3aUisOuHL69gYdy rOV95pz40iBwlDHlBwRIYDcz9SL5nsPyXW4StBo2tnNwBovYFDQGF2/sgC0ZiEns VD5aIAXfS2ukQVHTL5fAltv3gyNv2BpeH07boL3XZhMD/ywcrYqyJaRKFSwnIxQX +v6NAdQE+B5E3sgiQjKisTXlVIlWqzQ7s45uEhMnFHqfVs0L4EwMBeLBjc6xiy1k +c7SHpMinRWc4XgyqZ+X5A9f94ebtQJheesXH+0J+65IcpToQctQF40elZPpPeol n4TkBy3mPxOUHWLdeyDj1mdqqBhVMdBFPt0TX8MxdxpmrVHhVZHRTWMXZHynDbvr 7JBzXxWSKtNr6sD8p2KH5yEj3d6G83W36zCT2nFYe4ZMng9m207b5crPIfuNRMiX i6O6kkM0mZC2SvnnydpnmUQjorTnzjtOXMu0qN/9U1JrEZcV3ouOOHpdW30AZQuW T7KiSgiwX/GNxsmwqm8lVSym8NKzgZpmShL00JHObWScxitHJUjg8s0nNxXHtgh8 N+PRRb7gR34LQpl2y+mFhpexiclowg2QYt+Keo8Ao5EtoWpoeCI= =Wx69 -----END PGP SIGNATURE----- --=-=-=--