From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id 2NWiJy0IYWakrwAAe85BDQ:P1 (envelope-from ) for ; Thu, 06 Jun 2024 02:51:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 2NWiJy0IYWakrwAAe85BDQ (envelope-from ) for ; Thu, 06 Jun 2024 02:51:57 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=C9ImgxI7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1717635117; a=rsa-sha256; cv=none; b=cpno4KEc6TkPPr5gn6tti0+l9cvP9yNG1VdN81qF/QQcyAy+XS9BJzT39BqCpN1QVbIq2q iWlZXVf/2UBo7r8sAqotNraPL2+rHyfiWzNKhFfmFGevkU77Hgw7QDQtJ+zGEKQyeL9flJ m9R+roOisaMYeVeNWPjg+Hx/oaKzQl2EuIyQa1pvPYi7BQ3k2qYo1VuNjgsAQMctOJvbjz xYdq2bVBloJAethaqbrIDrwC68UyJl1ByWqZnTd6Jlq7JVyAJfyIOuohyQodxRmD9gVPlP 32LpHvwf2tH4cX8wu02uEbW/ldv6c4EGHo7RvX5WB3xn8T5GuUkRiQKF4mldmQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=C9ImgxI7; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1717635117; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Hm93P/zYQRFDhFm8vK9C1J7LKvtS01MgqAg+JIcdLj8=; b=VdBvmidfNlwynPyQr8iFsSlwc7bAURYpCmMHyxEHSEztB0PEG1V0vRpWnN5c3DBBKcoxV6 PCUvm4Q/YWMfLGvAk41Xx5u3PD5At1QR4aR5Uiknzkd4wEi7UozP4v87DtsP+5BViYhQUV VmEOnumlkTkCiGojjN45hzjofYDB91fgcJY4MaBzliWUEan7VyUHNc9sQPJ740bivH/mq8 lM838IwWW2OZ19ymJcyyckUBrvhDTTYWR77ah731izF0vknZAujYiIXXmdKcULj7MDwKhg MF1QB5GNL3UcBff3xfQWJ6ZU5r0pESpOp5lNRCb9RuKZsfJLcCRTq6RsnieK4Q== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6EC771EA03 for ; Thu, 6 Jun 2024 02:51:57 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sF1M4-0001WN-Np; Wed, 05 Jun 2024 20:51:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sF1M3-0001WF-WA for bug-guix@gnu.org; Wed, 05 Jun 2024 20:51:48 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sF1M3-0002Z2-OX for bug-guix@gnu.org; Wed, 05 Jun 2024 20:51:47 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sF1MI-0003nU-0P for bug-guix@gnu.org; Wed, 05 Jun 2024 20:52:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#47144: security patching of 'patch' package Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 06 Jun 2024 00:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47144 X-GNU-PR-Package: guix X-GNU-PR-Keywords: security To: Simon Tournier Cc: Mark H Weaver , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Leo Famulari , Vivien Kraus , 47144@debbugs.gnu.org Received: via spool by 47144-submit@debbugs.gnu.org id=B47144.171763507814489 (code B ref 47144); Thu, 06 Jun 2024 00:52:01 +0000 Received: (at 47144) by debbugs.gnu.org; 6 Jun 2024 00:51:18 +0000 Received: from localhost ([127.0.0.1]:52133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sF1La-0003ld-7U for submit@debbugs.gnu.org; Wed, 05 Jun 2024 20:51:18 -0400 Received: from mail-qv1-f52.google.com ([209.85.219.52]:43122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sF1LY-0003lK-NF for 47144@debbugs.gnu.org; Wed, 05 Jun 2024 20:51:17 -0400 Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-6af4fcb45ccso12592716d6.0 for <47144@debbugs.gnu.org>; Wed, 05 Jun 2024 17:51:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717634997; x=1718239797; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Hm93P/zYQRFDhFm8vK9C1J7LKvtS01MgqAg+JIcdLj8=; b=C9ImgxI79mDTifCHSDc0G+YCm4osHRsiZsb7EO8fyZYKqrLY52I/RhkMur1GV8IlU4 KzkgJRkI3PEd7Jtlrv9Jk+jvlzGV+tkZPhBaH8Sl/vIN0iswcmIrL1q0n9LBOZGJ7kHh BpLON/yjL4TV96uUmb4J4kwgrwCSq7/GQfToxzdRNQQZIhII4nYTT+lBv9DuYBLCAS0h yFuyfJltUk3duVltw9nUnxlNAQiXCxidmQ/d/ATnmoHpTv/cB/boA/se3aUF7uj9yzWk P69IVbyeFmQZ6yeZvxIIFJZrndu0nZvXFyzLIYsR1N91OyM2l59i1AoRU6Fv1CIxbO28 qHYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717634997; x=1718239797; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Hm93P/zYQRFDhFm8vK9C1J7LKvtS01MgqAg+JIcdLj8=; b=Otu5bqcLVp30jNc/E+ru1LaqSMs0yZPF7tHi7P50kobsBO1kfPTZ0xxnSVjm21bs6g g9x+oITo8astN2Ok80BKzcIOIP6ZJoYEOfYeVzME4WuHWvjm8KBUtmTDhCrA+7bpfBbQ X+Zk1yd/3v4jQ7+64UbGXCZdcljFtKT19g/nTrGtJR9F59rzixJw5zdzbmzIR5kVbRqW cYjn/q8hNlwXbciy0UXo90X/RuDslUWZiB3CC43YlugCm81A56de9KQjjf58WE2DuXsY 19BpyJ6GkdFqCiGP0V+sWTl+FlgcpXLpnMoQI4iU8w4DHhTPSF78NBeYQgIpEDje/jLh 9L2Q== X-Forwarded-Encrypted: i=1; AJvYcCXbROoQhRk7zrp2mDM/2RQwtYZDJuvc5EJv7HyZbKZaR1+eU93+h6j1TOKYMRdObB4dqRuE9BYDCAV64ZXxIcljvapk22U= X-Gm-Message-State: AOJu0YxOt61QFg1Rk/sAbIfBt+GLWp591/8W79XjQASfB4LQqRsL3nLc jl2MbMZ42FmkvPfxwRto87+yXoLsa2aSipcGBtlp3pB2vbCRULXK X-Google-Smtp-Source: AGHT+IHMBmqycDA+mbARCh3Rkz+ldPiVsZKrq2eRIQ8ELk5yEp/750bVzJBOvpH6DIbFPwDyIXxKWg== X-Received: by 2002:a05:6214:1cc6:b0:6ad:84aa:2956 with SMTP id 6a1803df08f44-6b04c00aedfmr24434926d6.13.1717634996661; Wed, 05 Jun 2024 17:49:56 -0700 (PDT) Received: from hurd (dsl-10-133-150.b2b2c.ca. [72.10.133.150]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b04f712e00sm1136106d6.61.2024.06.05.17.49.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 17:49:56 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <87a5jznxtz.fsf@gmail.com> (Simon Tournier's message of "Wed, 05 Jun 2024 18:44:40 +0200") References: <28b457771ab0e7ad87cb65600a5898f68be5074a.1717124361.git.maxim.cournoyer@gmail.com> <5eda21a09360653b198f1b0d7f52cf531dc97485.1717124361.git.maxim.cournoyer@gmail.com> <87r0dgn36w.fsf@gnu.org> <875xusln8m.fsf@gmail.com> <878qzj74vc.fsf_-_@gnu.org> <87a5jznxtz.fsf@gmail.com> Date: Wed, 05 Jun 2024 20:49:54 -0400 Message-ID: <87ikym3nf1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 6EC771EA03 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: 5.66 X-Spam-Score: 5.66 X-TUID: ZfxxB8xYMYde Hi Simon, Simon Tournier writes: > Hi, > > On Wed, 05 Jun 2024 at 18:04, Ludovic Court=C3=A8s wrote: > >> What about renaming =E2=80=98patch=E2=80=99 to =E2=80=98patch/pinned=E2= =80=99 and having =E2=80=98patch=E2=80=99 point >> to the new version? >> >> Internally, we=E2=80=99d refer to =E2=80=98patch/pinned=E2=80=99 in (gui= x packages), but user >> code etc. would refer to =E2=80=98patch=E2=80=99 and thus get the latest= version. > > I agree; it appears to me =E2=80=9Csafer=E2=80=9D than the graft. > > However, the cost is to identify which package needs =E2=80=99patch/pinne= d=E2=80=99 and > which needs new =E2=80=99patch=E2=80=99. Then once upstream Patch upgrad= es, there is > also the question to unpin all the packages. Indeed. It'll be easy though to grep for 'patch/pinned', which are far and few in between, compared to grepping for 'patch'... I've implemented Ludovic's suggestion in v4, before I actually read this reply of yours... I think it's OK; it goes a bit further than 'patch-latest' to protect users in case they refer to the 'patch' package variable directly. --=20 Thanks, Maxim