From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id yI0VNQriAmdn1AAA62LTzQ:P1 (envelope-from ) for ; Sun, 06 Oct 2024 19:16:26 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id yI0VNQriAmdn1AAA62LTzQ (envelope-from ) for ; Sun, 06 Oct 2024 21:16:26 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="tYsC/G28"; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=SE2LTP5e; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1728242186; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=U2M4dT5pXPjeHPH2yMRsouW+Vqhx88Wb0GLpSM0+pQo=; b=eMvsEbwj1PBi4wyOSAzM5mxQ0gw3z0IY1yBnhry2dpvW2SGmKaudGmkLcu3ftCtzOcE4KF Yo5mTOG7ZjGpsUblAfHoBurrcLvsIFTFp66c1N//4RAahr+uAKS9NknOI7nll/BXDLso/A tPxYlTZX2vNVgvpiIjXvLSeRPUTUdU9Er8g7DzhEzqJ0H9YcllSUht/KAYI9cDGPZP+kxf IalouXAcH97kWNLnngNJYhBecs3yKIsKm7ARS158GLp9idHZH2GMKwsgPVzd5EBdAPDOtq 7J6h0jAEqyck6MSmsJZvihnM+ikZI4NrQ5gl+LlVgf7ohlM5FCvbdU6SIBkKeA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1728242186; a=rsa-sha256; cv=none; b=uqzoL9YLXrhG/QPiJJvWuIpW9Qat2Pt509fSnIdYS3I7qbwmh5Qj9kE1F9efHr1x+Ytz7f v8CHrgrRAV5+xpJLrvsgc7Oc61kHxPfejZ43sW2Yg/fssbNuj5xVCO73cVAQGuV7FrXBkt z+jOZGjH5ABDI9UBeUnLOeLCuW/46OwZKJpFyXzdDbynkkt9cP6mQSVcmVohmCmcji2wez lziCsRVXtEatbeG4ftR3HR1ZrFDycKuxxNPlJbHoF/4eEZk1IPchlIOlKqMoPVu4KOczaw QMC6tpzMQgRSexer2x1wb7E3ZPulOCnXBIXzDwp2lB9u4mebfiZQ5yRq/t0yzQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="tYsC/G28"; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=SE2LTP5e; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5D6D37AB56 for ; Sun, 06 Oct 2024 21:16:26 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sxWjc-0007O4-4t; Sun, 06 Oct 2024 15:16:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sxWjW-0007NL-9H for guix-patches@gnu.org; Sun, 06 Oct 2024 15:15:58 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sxWjT-0006XX-VG for guix-patches@gnu.org; Sun, 06 Oct 2024 15:15:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=U2M4dT5pXPjeHPH2yMRsouW+Vqhx88Wb0GLpSM0+pQo=; b=tYsC/G28pYpOVO9EkY0jkPkX34mH1NU92rCRIgKUUprhazNUpxzl8hda+hR/Z2wkhW9SX1CHB9hX+/AIANMRG8TfdxB9sf9MoPULgrGhpMRGU0pcCe/vyWwqs3QhVCUj1CaQ4fLIg6bVCmKCWUxB9XnMRlnLKjWLmmTLApat6Wla38R/wzfyLdyEwOCn0ZM7P2yINaWnM5Qy+9bXwlg1fYKiACc8v6Zwm9QflxtkmHQknaqMbAiEfUMe2sDsyStG94BhLQyviMtXKdz0+V6Jh8a6mBvQfuePym/eQRmur3zsUtQb1I4jraLKKOMr6cVc8HqtZfzpkpRbwTPw+t8UYA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sxWjZ-0003Gw-Pd for guix-patches@gnu.org; Sun, 06 Oct 2024 15:16:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#69276] 01/04: gnu: libtorrent-rasterbar: Update to 2.0.10. Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Oct 2024 19:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69276 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tomas Volf <~@wolfsden.cz>, guix-devel@gnu.org Cc: 69276@debbugs.gnu.org, Z572 , Adam Faiz Received: via spool by 69276-submit@debbugs.gnu.org id=B69276.172824213512542 (code B ref 69276); Sun, 06 Oct 2024 19:16:01 +0000 Received: (at 69276) by debbugs.gnu.org; 6 Oct 2024 19:15:35 +0000 Received: from localhost ([127.0.0.1]:42316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxWj9-0003GD-9S for submit@debbugs.gnu.org; Sun, 06 Oct 2024 15:15:35 -0400 Received: from mail-4316.protonmail.ch ([185.70.43.16]:46221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxWj7-0003Fz-A9 for 69276@debbugs.gnu.org; Sun, 06 Oct 2024 15:15:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1728242121; x=1728501321; bh=U2M4dT5pXPjeHPH2yMRsouW+Vqhx88Wb0GLpSM0+pQo=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=SE2LTP5evNEKUePRon9yOY8BBwAw6eWTWrPkBQ8+DQA7az/VTO1qCkP+FT0rNRxaO wGvXOmeLiUEnlml/8aszsiWRjeUL9vwclua2oe/2ECkS2n4RFs4A1hG3sRPjcFnQ04 CtRBT1YBWIJj4RfQij+ZyR4SibO+colm2v1yY1jGQaZoZcy8MsTXfHeQ2lkjhgpbxC 4IgbFYYjg8OvhMROGiubA8vPN0uWJ6IxU/8u1tN3s1Ldbwgot5FGuSo+TeaNL79byz 0m497k4t1RlwPx+X4H3gkGJfZ/UpCqQx685EGgeqqAQHkQeSMMyaYp2sEhJQ/IJdwn eQnbhLprkobrw== Date: Sun, 06 Oct 2024 19:15:16 +0000 Message-ID: <87iku53uwy.fsf@protonmail.com> In-Reply-To: <87y131xgoa.fsf@wolfsden.cz> References: <172820540113.1389510.12193329113919899297@vcs3.savannah.gnu.org> <20241006090321.C8D6A1C1D84@vcs3.savannah.gnu.org> <87y131xgoa.fsf@wolfsden.cz> Feedback-ID: 7805494:user:proton X-Pm-Message-ID: a3d6ba2fdfa4e6d47fb03d08b95936d6131d9600 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: John Kehayias X-ACL-Warn: , John Kehayias via Guix-patches From: John Kehayias via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -3.36 X-Spam-Score: -3.36 X-Migadu-Queue-Id: 5D6D37AB56 X-Migadu-Scanner: mx13.migadu.com X-TUID: tSASotC1xqmV Dear Tomas (and CC'ing the debbugs number, co-author, and committer Z572), On Sun, Oct 06, 2024 at 07:52 PM, Tomas Volf wrote: > guix-commits@gnu.org writes: > >> z572 pushed a commit to branch master >> in repository guix. >> >> commit 37dede4c4d8c25a786f2a2e2a17ba54b4ba6283f >> Author: Adam Faiz via Guix-patches via >> AuthorDate: Tue Aug 6 21:07:40 2024 +0800 > > I have to admit I am not very happy regarding the change in the commit > author. While I understand the change itself might have been somewhat > trivial, I did work with upstream to merge the required changes for > 2.0.10, so having the authorship stolen like this leaves somewhat > unpleasant feeling. > I understand your frustration and while I thank you for bringing this to at= tention (we care about attribution here!), I do think this was escalated a = tiny bit in the heat of the moment. I don't see this message in the origina= l patch thread with the other author (Adam) and committer (Z572, still rela= tively new), so it is quite possible they didn't see this message you sent = until now. I should say, I do think it is good to raise awareness so we can all do bet= ter, but I think we should try to give some benefit of the doubt and look f= or the best way forward. Mistakes happen! I had accidentally lost the autho= r of some commits and realized after I had pushed them, raising this after = with guix-devel and the original authors for what remedy they would like. T= hough everything was okay, I felt bad, and still do, but at least it has ma= de me more vigilant. Let's remember we are all trying our best here and ima= gine ourselves on the other side. (Side note that upstream work to help out Guix and packaging is always welc= ome, so thank you for that! Though that is separate from authorship of comm= its on the Guix side, of course.) > Especially since applying for commit access has a number of commits as > one of prerequisites, having your address visible in `git log --author' > goes from "collecting internet points" into "actually somewhat > important". But even without that, I would still consider it not a nice > thing to do. > Part of having commit access is also accepting that mistakes will happen an= d you are expected to remedy, learn, and help us all do better (e.g. see ). This qu= ality I would say is much more important than just number of contributions,= though that experience is a more quantifiable prerequisite. As I hope a neutral third party, in this case I would suggest reverting the= commits and then reapplying them with author/co-author set appropriately. = I think this issue should have been brought up more directly with the parti= es involved, whether or not cc-ing guix-devel helps here I can't say. As I = said, I at least take it as a reminder of our responsibilities and potentia= l mistakes when we have commit access. While I could of course take this ac= tion myself, in following the link above, I leave it to those involved firs= t. > Have a nice day, > Tomas Let me also thank you for your contributions! I look forward to one day see= ing you announced as a new committer as you continue to contribute. But I h= ope when you are on that side and make a mistake, as we all do, that you ar= e given the benefit of the doubt, a chance to rectify, and help us all do b= etter. John PS: I know tone is hard and easily (wrongly) assumed in written communicati= on. Let me stress that all I wrote was meant to be understanding to your pe= rspective and feelings (which I'm sure many would share in the same circums= tances!) while also helping us reach a mutually beneficial remedy.