[bug#74124] [PATCH] gnu: Add r-shinyvalidate.

[bug#74124] [PATCH] gnu: Add r-shinyvalidate.

[King, Spencer via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2: 0001-gnu-Add-r-shinyvalidate.patch --]
[-- Type: application/octet-stream, Size: 1707 bytes --]

From de8e00f7e2378bb6d452bc74aa95d02039e1a5b4 Mon Sep 17 00:00:00 2001
Message-Id: <de8e00f7e2378bb6d452bc74aa95d02039e1a5b4.1730327642.git.spencer.king@geneoscopy.com>
From: Spencer King <spencer.king@geneoscopy.com>
Date: Wed, 30 Oct 2024 22:33:38 +0000
Subject: [PATCH] gnu: Add r-shinyvalidate.

* gnu/packages/cran.scm (r-shinyvalidate): New variable.

Change-Id: I554561d62269dda612cb0de21c23a36ad313907c
---
 gnu/packages/cran.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 717e4eac89..f2beb76d1d 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -6003,6 +6003,26 @@ (define-public r-shinytree
 supports interactive trees, to enable rich, editable trees in Shiny.")
     (license license:expat)))
 
+(define-public r-shinyvalidate
+  (package
+    (name "r-shinyvalidate")
+    (version "0.1.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "shinyvalidate" version))
+       (sha256
+        (base32 "01qlqzp0g6782maj73yygmwlchhv4xcnlc7j0w3lp6dcj7qkzz68"))))
+    (properties `((upstream-name . "shinyvalidate")))
+    (build-system r-build-system)
+    (propagated-inputs (list r-glue r-htmltools r-rlang r-shiny))
+    (home-page "https://rstudio.github.io/shinyvalidate/")
+    (synopsis "Input Validation for Shiny Apps")
+    (description
+     "Improves the user experience of Shiny apps by helping to provide feedback when
+required inputs are missing, or input values are not valid.")
+    (license license:expat)))
+
 (define-public r-shinydashboard
   (package
     (name "r-shinydashboard")

base-commit: 39fc289fd66eb348062b05d9ab6acad817f386f6
-- 
2.34.1

[bug#74124]

[King, Spencer via Guix-patches via]

Pinging the R team since this patch has been unreviewed for a couple months. This is my first time pinging a specific team so please let me know if this is inappropriate or if there is something else I should do in the future.

Best,
Spencer

bug#74124: [PATCH] gnu: Add r-shinyvalidate.

[Ricardo Wurmus]

Hi Spencer,

> Pinging the R team since this patch has been unreviewed for a couple
> months. This is my first time pinging a specific team so please let me
> know if this is inappropriate or if there is something else I should
> do in the future.

My apologies for the delay.  I had not previously seen this patch.
Pinging the team (even much sooner than you did) is certainly the right
thing to do.  It is also recommended to Cc the team when submitting the
patch.  (I don't know if you've done that.)

I've just applied the patch and made a few minor changes, including the
addition of r-testthat, which is now necessary with changes to the
r-build-system.

-- 
Ricardo

[bug#74124] [PATCH] gnu: Add r-shinyvalidate.

[King, Spencer via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 1292 bytes --]

Hi Ricardo,

Thank you for the quick response. Is r-testthat now necessary across the board for all R packages? I do have a couple of other outstanding R patches that I can update if needed and ping the team.

Best,
Spencer
________________________________
From: Ricardo Wurmus <rekado@elephly.net>
Sent: Friday, January 3, 2025 12:20 PM
To: 74124-done@debbugs.gnu.org <74124-done@debbugs.gnu.org>
Cc: King, Spencer <spencer.king@wustl.edu>; laurent.gatto@gmail.com <laurent.gatto@gmail.com>; zimon.toutoune@gmail.com <zimon.toutoune@gmail.com>
Subject: [PATCH] gnu: Add r-shinyvalidate.

Hi Spencer,

> Pinging the R team since this patch has been unreviewed for a couple
> months. This is my first time pinging a specific team so please let me
> know if this is inappropriate or if there is something else I should
> do in the future.

My apologies for the delay.  I had not previously seen this patch.
Pinging the team (even much sooner than you did) is certainly the right
thing to do.  It is also recommended to Cc the team when submitting the
patch.  (I don't know if you've done that.)

I've just applied the patch and made a few minor changes, including the
addition of r-testthat, which is now necessary with changes to the
r-build-system.

--
Ricardo

[-- Attachment #2: Type: text/html, Size: 3078 bytes --]

[bug#74124] [PATCH] gnu: Add r-shinyvalidate.

[Ricardo Wurmus]

"King, Spencer" <spencer.king@wustl.edu> writes:

> Is r-testthat now necessary across the board for all R packages?

That depends on the package.  Some use r-runit, others r-testit, some
use a combination of these packages, some use none at all.

Prior to my changes the build system would ignore test failures.  Most
test suites simply weren't run at all due to missing inputs.

-- 
Ricardo