From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add tmux.  licenses: add ISC.
Date: Mon, 11 Feb 2013 09:18:16 +0100
Message-ID: <87halj462f.fsf@gnu.org>
References: <1360550959-6069-1-git-send-email-tipecaml@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:33884)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1U4oah-0000VU-Us
	for bug-guix@gnu.org; Mon, 11 Feb 2013 03:18:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1U4oag-0003K0-Co
	for bug-guix@gnu.org; Mon, 11 Feb 2013 03:18:19 -0500
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:61606)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1U4oag-0003JO-7O
	for bug-guix@gnu.org; Mon, 11 Feb 2013 03:18:18 -0500
In-Reply-To: <1360550959-6069-1-git-send-email-tipecaml@gmail.com> (Cyril
	Roelandt's message of "Mon, 11 Feb 2013 03:49:19 +0100")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: bug-guix@gnu.org

Hi,

Cyril Roelandt <tipecaml@gmail.com> skribis:

> Adding tmux was easy, I just had to add the ISC license (aka "the OpenBSD
> license") to guix/licenses.scm. If you're okay with that, I'll push the p=
atch.

Looks good to me.  Just a couple of comments:

> +             (uri (string-append
> +                    "http://downloads.sourceforge.net/project/tmux/tmux/=
tmux-"
> +                    version "/tmux-" version ".tar.gz"))

Please use mirror://sourceforge/tmus/tmux/tmux-... here (make sure you
got the URL right by testing it with guix-download.)

> +    (synopsis "A BSD-licensed terminal multiplexer")

Maybe just =E2=80=9Ca terminal multiplexer=E2=80=9D?

Feel free to push once changed accordingly.

Thanks!

Ludo=E2=80=99.