From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] pspp Date: Sat, 30 Nov 2013 23:15:31 +0100 Message-ID: <87haatv8n0.fsf@gnu.org> References: <20131130131824.GA4676@intra> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vmsp9-0005Mm-2l for guix-devel@gnu.org; Sat, 30 Nov 2013 17:15:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vmsp2-0003l7-TF for guix-devel@gnu.org; Sat, 30 Nov 2013 17:15:39 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:33834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vmsp2-0003ky-Lu for guix-devel@gnu.org; Sat, 30 Nov 2013 17:15:32 -0500 In-Reply-To: <20131130131824.GA4676@intra> (John Darrington's message of "Sat, 30 Nov 2013 14:18:24 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: John Darrington Cc: guix-devel@gnu.org Hi John, This looks great! I just have minor stylistic notes: John Darrington skribis: > From 69c6338775161fcba20f4ce9452b33fee90dc2d1 Mon Sep 17 00:00:00 2001 > From: John Darrington > Date: Sat, 30 Nov 2013 11:11:54 +0100 > Subject: [PATCH 1/2] gnu: Added gtksourceview > > * gnu/packages/gtk.scm: New package gtksourceview Rather: * gnu/packages/gtk.scm (gtksourceview): New variable. > + (uri (string-append "mirror://gnome/sources/gtksourceview/" = (string-take version 4) "/gtksourceview-" > + version ".tar.bz2")) Please try to keep lines below 80 chars. > + (inputs > + `( > + ("intltool" ,intltool) > + ("pkg-config" ,pkg-config) > + ("gtk" ,gtk+-2) > + ("libxml2" ,libxml2) > + > + ; These two are needed only to allow the tests to run successfully > + ("xorg-server" ,xorg-server) > + ("shared-mime-info" ,shared-mime-info) > + )) [...] > + (arguments > + `(#:phases=20 > + ; Unfortunately, some of the tests in "make check" are highly depe= ndent on the environment > + ; therefore, some black magic is required Please use the same style as the rest; in particular, no line break after an opening paren, no hanging closing parens, and two semicolons to introduce comments that are on line of their own (see =E2=80=98HACKING=E2= =80=99.) (Nice that you managed to get the X tests running, BTW!) > + (synopsis "A text widget that extends the standard gtk+ 2.x > +text widget GtkTextView.") Rather like =E2=80=9CWidget that extends GtkTextView from GTK+ 2.x=E2=80=9D= (no final period, no =E2=80=9CA=E2=80=9D.) > From 39f8989a6e9067002911257701f90776f5b5b608 Mon Sep 17 00:00:00 2001 > From: John Darrington > Date: Sat, 30 Nov 2013 13:54:46 +0100 > Subject: [PATCH 2/2] gnu: pspp: Enabled build of the gui > > * gnu/packages/math.scm (): Removed the --without-gui flag > and added the necessary inputs to build it. Should be =E2=80=98pspp=E2=80=99, not =E2=80=98=E2=80=99. OK to apply modulo these cosmetic changes. Could you post updated patches? Thanks! Ludo=E2=80=99.