From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 4/5] gnu: openssl: Fixed cross-compile issues.
Date: Sat, 14 Dec 2013 22:01:46 +0100
Message-ID: <87haabtadh.fsf@gnu.org>
References: <1387043002-6138-1-git-send-email-john@darrington.wattle.id.au>
	<1387043002-6138-4-git-send-email-john@darrington.wattle.id.au>
	<8761qruxg8.fsf@gnu.org> <20131214180259.GA6637@intra>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34103)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1VrwLT-0007TV-B0
	for guix-devel@gnu.org; Sat, 14 Dec 2013 16:02:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1VrwLN-0003ZX-5z
	for guix-devel@gnu.org; Sat, 14 Dec 2013 16:01:55 -0500
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:59004)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1VrwLM-0003ZO-Vm
	for guix-devel@gnu.org; Sat, 14 Dec 2013 16:01:49 -0500
In-Reply-To: <20131214180259.GA6637@intra> (John Darrington's message of "Sat,
	14 Dec 2013 19:02:59 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: John Darrington <john@darrington.wattle.id.au>
Cc: guix-devel@gnu.org

John Darrington <john@darrington.wattle.id.au> skribis:

> On Sat, Dec 14, 2013 at 06:57:59PM +0100, Ludovic Court??s wrote:
>=20=20=20=20=20=20
>      > @@ -52,8 +52,8 @@
>      >                       (string-append "--prefix=3D" out)))))
>      >         (alist-cons-before
>      >          'patch-source-shebangs 'patch-tests
>      > -        (lambda* (#:key inputs #:allow-other-keys)
>      > -          (let ((bash (assoc-ref inputs "bash")))
>      > +        (lambda* (#:key inputs native-inputs #:allow-other-keys)
>      > +          (let ((bash (assoc-ref ,@(if (%current-target-system) '=
(native-inputs) '(inputs)) "bash")))
>=20=20=20=20=20=20
>      This can???t possibly work.
>
> I did test it, both for native compilation and cross-compilation.  In bot=
h cases
>  it built succesfully (unlike before the patch).

Ah, sorry, I misread the unquoted part; apologies for that.

Still, I=E2=80=99d prefer the simpler (because it=E2=80=99s build-side code=
 only):

  (assoc-ref (or native-inputs inputs) "bash")

WDYT?

Could you send an updated patch if that=E2=80=99s fine with you?

Ludo=E2=80=99.