From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] utils: Clean trailing whitespace at end of SHELL
Date: Fri, 05 Sep 2014 10:11:33 +0200
Message-ID: <87ha0m32ru.fsf@gnu.org>
References: <87bnqv31hc.fsf@member.fsf.org> <87ppfb89n9.fsf@gnu.org>
	<878uly3beg.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38513)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XPocO-000378-Uw
	for guix-devel@gnu.org; Fri, 05 Sep 2014 04:11:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XPocJ-0002I1-FQ
	for guix-devel@gnu.org; Fri, 05 Sep 2014 04:11:40 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:59444)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XPocJ-0002Hs-8n
	for guix-devel@gnu.org; Fri, 05 Sep 2014 04:11:35 -0400
In-Reply-To: <878uly3beg.fsf@gmail.com> (Eric Bavier's message of "Fri, 05 Sep
	2014 00:05:10 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <ericbavier@gmail.com>
Cc: guix-devel@gnu.org

Eric Bavier <ericbavier@gmail.com> skribis:

> Ludovic Court=C3=A8s writes:
>
>> Eric Bavier <ericbavier@gmail.com> skribis:
>>
>>> I found an unfortunate bug in the last patch I made to
>>> patch-makefile-SHELL that would leave a trailing ' ' at the end of SHELL
>>> assignments.  This is fine for most packages, but caused
>>> gobject-introspection to fail building for me just now (for the curious:
>>> it effectively does an "(apply system* (string-split (string-append SHE=
LL
>>> " " "./libtool") #\space))" which causes sh to try to execute "")
>>
>> AFAIK trailing whitespace in assignments is ignored by =E2=80=98make=E2=
=80=99.
>>
>> I grepped gobject-introspection out of curiosity and couldn=E2=80=99t fi=
nd any
>> suspicious SHELL assignment.  Do you still have it around?
>
> E.g. gobject-introspection-1.38.0/giscanner/utils.py:124

Oh, I see.

>> The (string=3D? args "\n") seems specific and non-obvious.
>
> I thought so too.  Your suggestion does work.  With this patch, I was
> able to bootstrap and build gobject-introspection.
>
>
> From 11459384968f654c42ad7dba4443dada35191f5b Mon Sep 17 00:00:00 2001
> From: Eric Bavier <bavier@member.fsf.org>
> Date: Thu, 4 Sep 2014 09:19:24 -0500
> Subject: [PATCH] utils: Clean trailing whitespace at end of SHELL
>
> * guix/build/utils.scm (patch-makefile-SHELL): Remove trailing whitespace.

OK to commit!

Thanks,
Ludo=E2=80=99.