From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#19044: 'guix-register -p' should perform deduplication
Date: Thu, 13 Nov 2014 17:56:35 +0100
Message-ID: <87h9y3hwe4.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60631)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1Xoxil-000576-DH
	for bug-guix@gnu.org; Thu, 13 Nov 2014 11:58:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1Xoxic-0000Wy-6W
	for bug-guix@gnu.org; Thu, 13 Nov 2014 11:58:11 -0500
Received: from debbugs.gnu.org ([140.186.70.43]:34137)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1Xoxic-0000Wu-2a
	for bug-guix@gnu.org; Thu, 13 Nov 2014 11:58:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1Xoxib-00022s-Rv
	for bug-guix@gnu.org; Thu, 13 Nov 2014 11:58:01 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.19044.B.14158978277791@debbugs.gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60128)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XoxhO-0004Ka-5D
	for bug-guix@gnu.org; Thu, 13 Nov 2014 11:56:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XoxhE-000076-Th
	for bug-guix@gnu.org; Thu, 13 Nov 2014 11:56:46 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:54916)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XoxhE-00006v-NT
	for bug-guix@gnu.org; Thu, 13 Nov 2014 11:56:36 -0500
Received: from localhost (localhost [127.0.0.1])
	by hera.aquilenet.fr (Postfix) with ESMTP id 146283FA5
	for <bug-guix@gnu.org>; Thu, 13 Nov 2014 17:56:36 +0100 (CET)
Received: from hera.aquilenet.fr ([127.0.0.1])
	by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id lazaAHQt-j+U for <bug-guix@gnu.org>;
	Thu, 13 Nov 2014 17:56:35 +0100 (CET)
Received: from pluto (pluto.bordeaux.inria.fr [193.50.110.57])
	by hera.aquilenet.fr (Postfix) with ESMTPSA id D29BC1B0A
	for <bug-guix@gnu.org>; Thu, 13 Nov 2014 17:56:35 +0100 (CET)
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: 19044@debbugs.gnu.org

When used with -p (as is the case when building a disk/VM image),
=E2=80=98guix-register=E2=80=99 doesn=E2=80=99t do any deduplication in the=
 target store, as
noted in the source:

  /* XXX: When PREFIX is non-empty, store->linksDir points to the original
     store's '.links' directory, which means 'optimisePath' would try to li=
nk
     to that instead of linking to the target store.  Thus, disable
     deduplication in this case.  */
  if (optimize && prefix.empty ())
    {
      /* Make sure deduplication is enabled.  */
      settings.autoOptimiseStore =3D true;

      foreach (ValidPathInfos::const_iterator, i, infos)
	store->optimisePath (i->path);
    }

This should be fixed, but may need to diverge slightly from upstream
libstore.

Ludo=E2=80=99.