From: ludo@gnu.org (Ludovic Courtès)
To: 19044@debbugs.gnu.org
Subject: bug#19044: 'guix-register -p' should perform deduplication
Date: Thu, 13 Nov 2014 17:56:35 +0100 [thread overview]
Message-ID: <87h9y3hwe4.fsf@gnu.org> (raw)
When used with -p (as is the case when building a disk/VM image),
‘guix-register’ doesn’t do any deduplication in the target store, as
noted in the source:
/* XXX: When PREFIX is non-empty, store->linksDir points to the original
store's '.links' directory, which means 'optimisePath' would try to link
to that instead of linking to the target store. Thus, disable
deduplication in this case. */
if (optimize && prefix.empty ())
{
/* Make sure deduplication is enabled. */
settings.autoOptimiseStore = true;
foreach (ValidPathInfos::const_iterator, i, infos)
store->optimisePath (i->path);
}
This should be fixed, but may need to diverge slightly from upstream
libstore.
Ludo’.
next reply other threads:[~2014-11-13 16:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 16:56 Ludovic Courtès [this message]
2015-06-10 12:13 ` bug#19044: 'guix-register -p' should perform deduplication Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9y3hwe4.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=19044@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.