From: ludo@gnu.org (Ludovic Courtès)
To: Marek Benc <merkur32@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: problem with building gcc-cross-4.8.3 for i686-pc-gnu
Date: Thu, 05 Feb 2015 13:38:48 +0100 [thread overview]
Message-ID: <87h9v04jon.fsf@gnu.org> (raw)
In-Reply-To: <54CD5372.5090103@gmail.com> (Marek Benc's message of "Sat, 31 Jan 2015 23:13:06 +0100")
Marek Benc <merkur32@gmail.com> skribis:
> The attached patch does the following:
> 1.) Adds the name of the dynamic linker to gnu/packages/bootstrap.scm
> 2.) Adds code to gnu/package/gcc to substitute the default dynamic
> linker in gcc/config/arch/gnu.h for the one to be used.
> 3.) Changes how the build system arguments for cross-gcc are created:
> A.) They're now in a separate procedure, reflecting how it's done
> in vanilla guix.
> B.) A bug is fixed that caused the native ld.so to be picked over
> the target one.
> C.) Fixed the 'set-cross-path phase so that it also checks for
> hurd-related packages, and checks package existence before passing
> anything to the string-handling functions.
This all looks good to me. However, this should really be 5 different
patches so as to ease review, bisection, etc. Could you do that?
Please prefer one message per patch, as with ‘git send-email’.
TIA!
Ludo’.
next prev parent reply other threads:[~2015-02-05 12:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 10:27 problem with building gcc-cross-4.8.3 for i686-pc-gnu Marek Benc
2015-01-31 22:13 ` Marek Benc
2015-02-01 18:56 ` Marek Benc
2015-02-05 12:44 ` Ludovic Courtès
[not found] ` <54D3A92A.6060209@gmx.com>
[not found] ` <87h9v014wk.fsf@gnu.org>
2015-02-05 20:32 ` Marek Benc
2015-02-07 23:24 ` Ludovic Courtès
2015-02-05 12:38 ` Ludovic Courtès [this message]
2015-02-05 16:22 ` [PATCH 0/4] gnu: Fix ld.so detection of cross-compilers for the GNU Hurd system Marek Benc
-- strict thread matches above, loose matches on Subject: below --
2014-12-30 14:28 problem with building gcc-cross-4.8.3 for i686-pc-gnu Manolis Ragkousis
2015-01-03 21:27 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9v04jon.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=merkur32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.