[PATCH] build GTK2 typelib file

[PATCH] build GTK2 typelib file

[Ricardo Wurmus]

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

Hi Guix,

GTK2 does not install its typelib file, which is needed by applications
using GTK through gobject introspection.

The attached patch fixes this by adding "gobject-introspection" to the
native inputs.  An additional make flag is required to use "gcc" rather
than "cc".

Is the commit message okay?
Should this be applied to core updates instead of master?

~~ Ricardo


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-gtk-2-build-gobject-introspection-typelib-file.patch --]
[-- Type: text/x-patch, Size: 997 bytes --]

From a71d408351e54031a1bb0ecb143128a5512fc75e Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <rekado@elephly.net>
Date: Sun, 15 Mar 2015 23:12:32 +0100
Subject: [PATCH] gnu: gtk+-2: build gobject introspection typelib file.

* gnu/packages/gtk.scm (gtk+-2): add `gobject-introspection' to the
  native-inputs to install typelib file.
---
 gnu/packages/gtk.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index fef5a81..b3688d5 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -408,10 +408,12 @@ is part of the GNOME accessibility project.")
    (native-inputs
     `(("perl" ,perl)
       ("glib" ,glib "bin")
+      ("gobject-introspection" ,gobject-introspection)
       ("pkg-config" ,pkg-config)
       ("python-wrapper" ,python-wrapper)))
    (arguments
-    `(#:phases
+    `(#:make-flags '("CC=gcc")
+      #:phases
       (alist-cons-before
        'configure 'disable-tests
        (lambda _
-- 
2.1.0

Re: [PATCH] build GTK2 typelib file

[Ludovic Courtès]

Ricardo Wurmus <rekado@elephly.net> skribis:

> GTK2 does not install its typelib file, which is needed by applications
> using GTK through gobject introspection.

Good catch.

> From a71d408351e54031a1bb0ecb143128a5512fc75e Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Sun, 15 Mar 2015 23:12:32 +0100
> Subject: [PATCH] gnu: gtk+-2: build gobject introspection typelib file.
>
> * gnu/packages/gtk.scm (gtk+-2): add `gobject-introspection' to the
>   native-inputs to install typelib file.

LGTM.

Could you push it to a separate branch?  Then we’ll get Hydra to build
it and merge it when it’s done (136 packages depend on GTK+.)

Thanks,
Ludo’.

Re: [PATCH] build GTK2 typelib file

[Ricardo Wurmus]

Ludovic Courtès writes:

>> From a71d408351e54031a1bb0ecb143128a5512fc75e Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <rekado@elephly.net>
>> Date: Sun, 15 Mar 2015 23:12:32 +0100
>> Subject: [PATCH] gnu: gtk+-2: build gobject introspection typelib file.
>>
>> * gnu/packages/gtk.scm (gtk+-2): add `gobject-introspection' to the
>>   native-inputs to install typelib file.
>
> LGTM.
>
> Could you push it to a separate branch?  Then we’ll get Hydra to build
> it and merge it when it’s done (136 packages depend on GTK+.)

I pushed the commit to the new branch "gtk-rebuild", based on latest
master.

Could someone please ask Hydra to build the packages?

~~ Ricardo

Re: [PATCH] build GTK2 typelib file

[Andreas Enge]

On Fri, Mar 20, 2015 at 10:57:07PM +0100, Ricardo Wurmus wrote:
> Could someone please ask Hydra to build the packages?

Done.

Andreas

Re: [PATCH] build GTK2 typelib file

[Ricardo Wurmus]

Andreas Enge writes:

> On Fri, Mar 20, 2015 at 10:57:07PM +0100, Ricardo Wurmus wrote:
>> Could someone please ask Hydra to build the packages?
>
> Done.

Thank you!  (Right now hydra seems not to respond, though.)

Re: [PATCH] build GTK2 typelib file

[Mark H Weaver]

Andreas Enge <andreas@enge.fr> writes:

> On Fri, Mar 20, 2015 at 10:57:07PM +0100, Ricardo Wurmus wrote:
>> Could someone please ask Hydra to build the packages?
>
> Done.

This is a waste because it's not built on top of the 'openssl-update'
branch, which will render all of those builds obsolete.  Also, since the
openssl update includes important security fixes, we should prioritize
that for now.  Therefore, I've deleted the gtk-rebuild jobset for now.
After we've applied the openssl update to master and rebased
'gtk-rebuild' on top of that, we can ask Hydra to build it.

      Mark

Re: [PATCH] build GTK2 typelib file

[Mark H Weaver]

Mark H Weaver <mhw@netris.org> writes:

> Andreas Enge <andreas@enge.fr> writes:
>
>> On Fri, Mar 20, 2015 at 10:57:07PM +0100, Ricardo Wurmus wrote:
>>> Could someone please ask Hydra to build the packages?
>>
>> Done.
>
> This is a waste because it's not built on top of the 'openssl-update'
> branch, which will render all of those builds obsolete.  Also, since the
> openssl update includes important security fixes, we should prioritize
> that for now.  Therefore, I've deleted the gtk-rebuild jobset for now.
> After we've applied the openssl update to master and rebased
> 'gtk-rebuild' on top of that, we can ask Hydra to build it.

This is all done now.  I applied Ricardo's commit to master and deleted
the 'gtk-rebuild' branch.

     Thanks!
       Mark

Re: [PATCH] build GTK2 typelib file

[Ludovic Courtès]

Mark H Weaver <mhw@netris.org> skribis:

> Mark H Weaver <mhw@netris.org> writes:
>
>> Andreas Enge <andreas@enge.fr> writes:
>>
>>> On Fri, Mar 20, 2015 at 10:57:07PM +0100, Ricardo Wurmus wrote:
>>>> Could someone please ask Hydra to build the packages?
>>>
>>> Done.
>>
>> This is a waste because it's not built on top of the 'openssl-update'
>> branch, which will render all of those builds obsolete.  Also, since the
>> openssl update includes important security fixes, we should prioritize
>> that for now.  Therefore, I've deleted the gtk-rebuild jobset for now.
>> After we've applied the openssl update to master and rebased
>> 'gtk-rebuild' on top of that, we can ask Hydra to build it.
>
> This is all done now.  I applied Ricardo's commit to master and deleted
> the 'gtk-rebuild' branch.

Thanks for handling this!

Ludo’.