From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/3] gnu: Add UnQLite.
Date: Sun, 29 Mar 2015 15:49:42 +0200
Message-ID: <87h9t3ykuh.fsf@gnu.org>
References: <1427491480-27319-1-git-send-email-bavier@member.fsf.org>
	<1427491480-27319-3-git-send-email-bavier@member.fsf.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46047)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YcDb3-0001zU-7A
	for guix-devel@gnu.org; Sun, 29 Mar 2015 09:49:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YcDaz-0004lE-MR
	for guix-devel@gnu.org; Sun, 29 Mar 2015 09:49:49 -0400
In-Reply-To: <1427491480-27319-3-git-send-email-bavier@member.fsf.org> (Eric
	Bavier's message of "Fri, 27 Mar 2015 16:24:39 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Bavier <bavier@member.fsf.org>
Cc: guix-devel@gnu.org

Eric Bavier <bavier@member.fsf.org> skribis:

> * gnu/packages/databases.scm (unqlite): New variable.

[...]

> +              ;; Contiains bug-fixes against the official release, and h=
as an
                       ^^^       ^
Typo.

> +              ;; autotooled build system.
> +              (uri (string-append "https://github.com/aidin36/tocc/relea=
ses/"
> +                                  "download/v1.0.0/"
> +                                  "unqlite-unofficial-" version ".tar.gz=
"))

Still, it seems that we should be using the official version no?

> +    (synopsis "NoSQL database engine")

=E2=80=9CNoSQL=E2=80=9D says what it=E2=80=99s not, but not what it is.  Ma=
ybe =E2=80=9CIn-memory
key/value database=E2=80=9D (IIUC) or something to that effect?

The rest LGTM.

Thanks!

Ludo=E2=80=99.