From: Alex Kost <alezost@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: Bugs in parsing build options
Date: Sat, 30 May 2015 19:26:25 +0300 [thread overview]
Message-ID: <87h9qunia6.fsf@gmail.com> (raw)
In-Reply-To: <87oaoh1tiw.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 26 Feb 2015 00:05:43 +0100")
Ludovic Courtès (2015-02-26 02:05 +0300) wrote:
> Alex Kost <alezost@gmail.com> skribis:
>
>> Suppose a user specifies "--no-substitutes" in his GUIX_BUILD_OPTIONS
>> and then he calls "guix system reconfigure". What would happen?
>> Substitutes _will be used_ anyway, because:
>> ‘(parse-options-from args)’ will contain ‘(substitutes? . #t)’ among
>> other things and it will shadow the false value for substitutes returned
>> by ‘(parse-options-from (environment-build-options))’.
>>
>> Now (after your patch) the same will happen with "--no-grub":
>> “export GUIX_BUILD_OPTIONS=--no-grub” will not be honored unless a user
>> explicitly specifies "--no-grub" option one more time in a "guix system"
>> command.
>
> Oh, that’s right. AFAICS, commit cf6ce3e fixes it.
>
> It was a good opportunity to factorize all that and to add tests.
I think I've found that there are still some problems in parsing options.
1. The following command:
GUIX_BUILD_OPTIONS="--no-grub" guix package --help
gives the following error:
guix package: error: no-grub: unrecognized option
So it makes impossible to use GUIX_BUILD_OPTIONS env var or did I miss
anything?
2. The manual says that ‘guix package’ «supports all the common build
options that ‘guix build’ supports» and the following command works
perfectly:
guix build --system=i686-linux hello
However, the following command:
guix package --system=i686-linux --install hello
gives an error again:
guix package: error: system=i686-linux: unrecognized option
--
Alex
next prev parent reply other threads:[~2015-05-30 16:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAJ41eeyECrUPfEhS+9puU3y0iczEeCs8JgKB8RnTRofVNOW_4w@mail.gmail.com>
2014-12-05 0:53 ` [PATCH] guix: scripts: Fix GUIX_BUILD_OPTIONS handling Deck Pickard
2014-12-06 15:04 ` Ludovic Courtès
2015-02-20 20:47 ` Bugs in parsing build options Alex Kost
2015-02-24 22:45 ` Ludovic Courtès
2015-02-25 14:38 ` Alex Kost
2015-02-25 23:05 ` Ludovic Courtès
2015-02-26 21:08 ` Alex Kost
2015-05-30 16:26 ` Alex Kost [this message]
2015-05-31 19:32 ` Ludovic Courtès
2015-06-01 6:52 ` Alex Kost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9qunia6.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.