From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 10/14] gnu: Add MUMPS.
Date: Sun, 28 Jun 2015 22:12:40 +0200
Message-ID: <87h9prvbgn.fsf@gnu.org>
References: <1435463151-32099-1-git-send-email-ericbavier@openmailbox.org>
	<1435463151-32099-11-git-send-email-ericbavier@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49716)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Z9Iwb-0004sm-0d
	for guix-devel@gnu.org; Sun, 28 Jun 2015 16:12:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Z9IwZ-0006sx-Sl
	for guix-devel@gnu.org; Sun, 28 Jun 2015 16:12:48 -0400
In-Reply-To: <1435463151-32099-11-git-send-email-ericbavier@openmailbox.org>
	(ericbavier@openmailbox.org's message of "Sat, 27 Jun 2015 22:45:47
	-0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: ericbavier@openmailbox.org
Cc: guix-devel@gnu.org, Eric Bavier <bavier@member.fsf.org>

ericbavier@openmailbox.org skribis:

> From: Eric Bavier <bavier@member.fsf.org>
>
> * gnu/packages/maths.scm (mumps, mumps-metis, mumps-openmpi)
>   (mumps-metis-openmpi): New variables.
> * gnu/packages/patches/mumps-build-parallelism.patch: New patch.
> * gnu-system.am (dist_patch_DATA): Add it.

ISTR that some time ago MUMPS included obfuscated code; I assume this is
no longer the case?

> +            (zero? (system* "make" "all"
> +                            (format #f "-j~a" (current-processor-count))=
))))

Rather =E2=80=98parallel-job-count=E2=80=99.

> +          (lambda* (#:key (exec-prefix '()) #:allow-other-keys)
> +            (with-directory-excursion "examples"
> +              (use-modules (srfi srfi-1))
> +              (every
> +               (lambda (prec type)
> +                 (use-modules (ice-9 popen))

Local =E2=80=98use-modules=E2=80=99 forms are not very nice (it=E2=80=99s n=
ot documented.)
Rather use:

  #:modules ((srfi srfi-1)
             (ice-9 popen)
             ,@%gnu-build-system-modules)

> +                 (let ((tester (apply open-pipe*
> +                                      `(,OPEN_WRITE
> +                                        ,@exec-prefix
> +                                        ,(string-append "./" prec
> +                                                        "simpletest"))))
> +                       (input  (open-input-file
> +                                (string-append "input_simpletest_" type)=
)))
> +                   (begin
> +                     (dump-port input tester)
> +                     (close-port input)
> +                     (zero? (close-pipe tester)))))
> +               '("s" "d" "c" "z")
> +               '("real" "real" "cmplx" "cmplx")))))

Please add a comment saying that this does, to appease the reader.  ;-)

> +    (license license:public-domain)))

I think it=E2=80=99s CeCILL-C, see
<http://mumps.enseeiht.fr/index.php?page=3Ddwnld>.

OK with these changes!

Thanks,
Ludo=E2=80=99.