From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 3/3] gnu: Add python-pelican
Date: Sun, 19 Jul 2015 23:27:45 +0200
Message-ID: <87h9ozj0ry.fsf@gnu.org>
References: <87h9pbwt9b.fsf@earlgrey.lan>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57051)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZGw7m-0004hS-IE
	for guix-devel@gnu.org; Sun, 19 Jul 2015 17:27:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZGw7j-00076i-Bt
	for guix-devel@gnu.org; Sun, 19 Jul 2015 17:27:54 -0400
In-Reply-To: <87h9pbwt9b.fsf@earlgrey.lan> (Christopher Allan Webber's message
	of "Fri, 10 Jul 2015 17:18:39 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: guix-devel@gnu.org

Christopher Allan Webber <cwebber@dustycloud.org> skribis:

> From 220db75dbf4700a8c9b342cf68dacce74d864d8a Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <cwebber@dustycloud.org>
> Date: Fri, 10 Jul 2015 16:28:01 -0500
> Subject: [PATCH 3/3] gnu: Add python-pelican
>
> * gnu/packages/python.scm (python-pelican): New variables.

[...]

> +    (inputs
> +     `(("python-setuptools" ,python-setuptools)

Move this one to =E2=80=98native-inputs=E2=80=99.

> +       ("python-feedgenerator" ,python-feedgenerator)
> +       ("python-jinja2" ,python-jinja2)
> +       ("python-pygments" ,python-pygments)
> +       ("python-docutils" ,python-docutils)
> +       ("python-pytz" ,python-pytz)
> +       ("python-blinker" ,python-blinker)
> +       ("python-unidecode" ,python-unidecode)
> +       ("python-six" ,python-six)
> +       ("python-dateutil-2" ,python-dateutil-2)))

If Pelican is simply meant to be used as a command-line tool, this is
fine.  Otherwise, if it=E2=80=99s meant as a Python library (or both), these
probably need to be moved to =E2=80=98propagated-inputs=E2=80=99.

> +    (arguments
> +     `(;; Requires a lot more packages to do unit tests :P
> +       #:tests? #f

Add =E2=80=9CXXX=E2=80=9D to make it more prominent.  :-)

> +    (synopsis
> +     "Python-based static site publishing system")

Keep it on a single line.

> +    (description
> +     "A tool to generate a static blog from reStructuredText, Markdown i=
nput files,

=E2=80=9CPelican is a tool...=E2=80=9D

> +    ;; No indication that this is "or later" in the source,
> +    ;; must assume AGPLv3 only
> +    (license agpl3)))

Unless the license version is explicitly specified somewhere, the
recipient can use any version of the license (per Section 14 of GPLv3),
which we=E2=80=99d translate it as =E2=80=98agpl3+=E2=80=99 here.

Could you send an updated patch?

TIA,
Ludo=E2=80=99.