From: ludo@gnu.org (Ludovic Courtès)
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 3/3] gnu: Add python-pelican
Date: Sun, 19 Jul 2015 23:27:45 +0200 [thread overview]
Message-ID: <87h9ozj0ry.fsf@gnu.org> (raw)
In-Reply-To: <87h9pbwt9b.fsf@earlgrey.lan> (Christopher Allan Webber's message of "Fri, 10 Jul 2015 17:18:39 -0500")
Christopher Allan Webber <cwebber@dustycloud.org> skribis:
> From 220db75dbf4700a8c9b342cf68dacce74d864d8a Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <cwebber@dustycloud.org>
> Date: Fri, 10 Jul 2015 16:28:01 -0500
> Subject: [PATCH 3/3] gnu: Add python-pelican
>
> * gnu/packages/python.scm (python-pelican): New variables.
[...]
> + (inputs
> + `(("python-setuptools" ,python-setuptools)
Move this one to ‘native-inputs’.
> + ("python-feedgenerator" ,python-feedgenerator)
> + ("python-jinja2" ,python-jinja2)
> + ("python-pygments" ,python-pygments)
> + ("python-docutils" ,python-docutils)
> + ("python-pytz" ,python-pytz)
> + ("python-blinker" ,python-blinker)
> + ("python-unidecode" ,python-unidecode)
> + ("python-six" ,python-six)
> + ("python-dateutil-2" ,python-dateutil-2)))
If Pelican is simply meant to be used as a command-line tool, this is
fine. Otherwise, if it’s meant as a Python library (or both), these
probably need to be moved to ‘propagated-inputs’.
> + (arguments
> + `(;; Requires a lot more packages to do unit tests :P
> + #:tests? #f
Add “XXX” to make it more prominent. :-)
> + (synopsis
> + "Python-based static site publishing system")
Keep it on a single line.
> + (description
> + "A tool to generate a static blog from reStructuredText, Markdown input files,
“Pelican is a tool...”
> + ;; No indication that this is "or later" in the source,
> + ;; must assume AGPLv3 only
> + (license agpl3)))
Unless the license version is explicitly specified somewhere, the
recipient can use any version of the license (per Section 14 of GPLv3),
which we’d translate it as ‘agpl3+’ here.
Could you send an updated patch?
TIA,
Ludo’.
next prev parent reply other threads:[~2015-07-19 21:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 22:18 [PATCH 3/3] gnu: Add python-pelican Christopher Allan Webber
2015-07-19 21:27 ` Ludovic Courtès [this message]
2015-07-21 1:22 ` Christopher Allan Webber
2015-07-26 22:30 ` Thompson, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9ozj0ry.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=cwebber@dustycloud.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.