From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 1/2] emacs: Add development utils.
Date: Tue, 22 Sep 2015 23:44:55 +0200
Message-ID: <87h9mmi0x4.fsf@gnu.org>
References: <1437814197-6321-1-git-send-email-alezost@gmail.com>
	<1437814197-6321-8-git-send-email-alezost@gmail.com>
	<87twrwu1ec.fsf@gnu.org> <877for2e9t.fsf_-_@gmail.com>
	<87fv368foo.fsf@gnu.org> <87io72e0ci.fsf_-_@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33905)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZeVMw-0006yJ-D9
	for guix-devel@gnu.org; Tue, 22 Sep 2015 17:44:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZeVMv-0007fZ-Go
	for guix-devel@gnu.org; Tue, 22 Sep 2015 17:44:58 -0400
In-Reply-To: <87io72e0ci.fsf_-_@gmail.com> (Alex Kost's message of "Tue, 22
	Sep 2015 22:10:53 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org

Alex Kost <alezost@gmail.com> skribis:

> Ludovic Court=C3=A8s (2015-08-26 14:14 +0300) wrote:
>
>> Alex Kost <alezost@gmail.com> skribis:
>>
>>> Ludovic Court=C3=A8s (2015-08-18 17:17 +0300) wrote:
>>>
> [...]
>>>> Also, what about suggesting or even defining a key binding for this on=
e?
>>>> It sounds very useful.
>>>
>>> There is an example of defining a key binding for a command in this
>>> section.  As for the real defining, not sure if it is worth, but yeah,
>>> why not.  We may define 'guix-minor-mode', for example, with
>>> guix-specific key bindings.  But I don't know what bindings to use:
>>> 'geiser-mode' already binds many commands to [C-c =E2=80=A6].  Perhaps =
to put
>>> the additional keys in [C-c g =E2=80=A6]?
>>
>> Yes, =E2=80=98guix-minor-mode=E2=80=99 and C-c g both sound like good id=
eas to me.
>
> Eventually I named it =E2=80=98guix-devel-mode=E2=80=99, and I made it en=
abled by
> default (in "emacs/guix-init.el"), as it just provides some keys and
> won't do any harm.  Is it OK?

Sounds good to me.

> As for the keys, I put them in [C-c .] "group", because according to
> (info "(elisp) Key Binding Conventions"), [C-c <letter>] bindings are
> reserved for users.  Do you have other suggestions for the keys?

No, I think it=E2=80=99s fine and it matches the elisp manual recommendatio=
ns.

> From 9e0541abe206e1e7409ea575acc824a26c2f62d5 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Fri, 24 Jul 2015 18:33:14 +0300
> Subject: [PATCH 1/2] emacs: Add development utils.
>
> * emacs/guix-guile.el (guix-guile-current-module): New function.
> * emacs/guix-devel.el: New file.
> * emacs.am (ELFILES): Add it.
> * doc/emacs.texi (Emacs Development): New node.
>   (Emacs Interface): Add it.
> * doc/contributing.texi (The Perfect Setup): Mention it.
> * doc/guix.texi (Top): Add it.
> * emacs/guix-init.el: Add 'guix-devel-activate-mode-maybe' to
>   'scheme-mode-hook'.

LGTM, thanks!

Ludo=E2=80=99.