From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH] Add Yoshimi.
Date: Thu, 24 Dec 2015 10:13:26 +0100
Message-ID: <87h9j86wg9.fsf@elephly.net>
References: <87si2t7gg4.fsf@elephly.net> <20151223192121.GB16116@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48281)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1aC1xo-00064q-2r
	for guix-devel@gnu.org; Thu, 24 Dec 2015 04:13:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1aC1xk-00029P-Sw
	for guix-devel@gnu.org; Thu, 24 Dec 2015 04:13:36 -0500
Received: from sender163-mail.zoho.com ([74.201.84.163]:25146)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1aC1xk-00029G-Ku
	for guix-devel@gnu.org; Thu, 24 Dec 2015 04:13:32 -0500
In-reply-to: <20151223192121.GB16116@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Leo Famulari <leo@famulari.name>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>


Leo Famulari <leo@famulari.name> writes:

> The readline module is not imported by music.scm on current master.
> Maybe you have a WIP patch that imports it in your tree? Anyways, the
> "readline" variable is currently unbound.
>
> It builds fine for me otherwise.

You’re right, I forgot to add it to the patch.

>> +       ("ncurses" ,ncurses)
>> +       ("cairo" ,cairo)
>> +       ("zlib" ,zlib)))
>> +    (native-inputs
>> +     `(("pkg-config" ,pkg-config)))
>> +    (home-page "http://yoshimi.sourceforge.net/")
>> +    (synopsis "Software synthesizer")
>
> Have you considered describing the "type" of synthesis here in the
> synopsis? For example, it could be additive, subtractive, frequency
> modulating, etc. Each synthesizer variable could have a synopsis like
> "Additive software synthesizer", etc. That would be a nice affordance
> for synth geeks :) 
>
> In this case, it looks like the synthesis type is "multi-paradigm".

I updated the synopsis to read “Multi-paradigm software synthesizer”.
Thanks for the suggestion and the review!

~~ Ricardo