From: ludo@gnu.org (Ludovic Courtès)
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add libcanberra-gtk2.
Date: Sun, 07 Feb 2016 21:15:10 +0100 [thread overview]
Message-ID: <87h9hktgz5.fsf@gnu.org> (raw)
In-Reply-To: <20160206215657.3f9fa800@debian-netbook> (Efraim Flashner's message of "Sat, 6 Feb 2016 21:56:57 +0200")
Efraim Flashner <efraim@flashner.co.il> skribis:
> On Sat, 6 Feb 2016 19:48:44 +0100
> Fabian Harfert <fhmgufs@web.de> wrote:
>
>> * gnu/packages/libcanberra.scm (libcanberra/gtk+-2): New variable.
[...]
>> +(define-public libcanberra/gtk+-2
>> + (package (inherit libcanberra)
>> + (name "libcanberra-gtk2")
>> + (inputs
>> + `(("alsa-lib" ,alsa-lib)
>> + ("gstreamer" ,gstreamer)
>> + ("gtk+" ,gtk+-2)
>> + ("libltdl" ,libltdl)
>> + ("libvorbis" ,libvorbis)
>> + ("pulseaudio" ,pulseaudio)
>> + ("udev" ,eudev)
>> + ("sound-theme-freedesktop" ,sound-theme-freedesktop)))))
>> +
>> (define-public sound-theme-freedesktop
>> (package
>> (name "sound-theme-freedesktop")
>
> gtk is the only different input between the two variants, how about just
> removing gtk from the list of inherited inputs and adding in gtk+-2?
Agreed. Fabian: could you send an updated patch? If you prefer one of
us could adjust your patch to do that.
Thanks,
Ludo’.
next prev parent reply other threads:[~2016-02-07 20:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 16:04 [PATCH] gnu: libcanberra: Add input gtk+-2 Fabian Harfert
2016-02-04 16:08 ` Fabian Harfert
2016-02-06 5:05 ` 宋文武
2016-02-06 18:48 ` [PATCH] gnu: Add libcanberra-gtk2 Fabian Harfert
2016-02-06 19:56 ` Efraim Flashner
2016-02-07 11:13 ` Andreas Enge
2016-02-07 13:41 ` Fabian Harfert
2016-02-07 14:03 ` Andreas Enge
2016-02-07 14:25 ` Efraim Flashner
2016-02-07 15:51 ` Andreas Enge
2016-02-07 20:15 ` Ludovic Courtès [this message]
2016-02-07 20:16 ` Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9hktgz5.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=efraim@flashner.co.il \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.