Re: [PATCH] gnu-build-system: do not patch symlinks. Fixes location-aware scripts.

[ludo@gnu.org (Ludovic Courtès)]

Jan Nieuwenhuizen <janneke@gnu.org> skribis:

> Ludovic Courtès writes:
>
>> How does the script determines its location?  Using $0 is unreliable,
>> and using /proc/self/exe is non portable.
>
> It uses node.js's __dirname.  I would have to dive into node.js
> internals to figure that out...  I would think it does /proc/self/exe
> and has fallbacks for other platforms?

That's plausible.

> From 2d17c6bd7c7dd466c0aee14beaa47055af0ceb6d Mon Sep 17 00:00:00 2001
> From: Jan Nieuwenhuizen <janneke@gnu.org>
> Date: Sun, 7 Feb 2016 16:45:25 +0100
> Subject: [PATCH] build-system/gnu: Do not patch symlinks, v2.
>
>     This fixes location-aware scripts.
>
>     * guix/build/gnu-build-system.scm (file-is-symlink?): new function.
>     (patch-source-shebangs): use it to skip symlinks.

This one changes ‘patch-source-shebangs’, which is about patching files
in the source tree.

It makes sense to avoid patching symlinks there too, but are you sure
this has anything to do with the problem you noticed?

Thanks,
Ludo’.