From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 06/10] gnu: Add libiconv.
Date: Tue, 03 May 2016 14:20:38 +0200
Message-ID: <87h9efbaeh.fsf@gnu.org>
References: <1461942751-23883-1-git-send-email-janneke@gnu.org>
	<1461942751-23883-6-git-send-email-janneke@gnu.org>
	<9b320678-3af9-22c5-ead5-23126e43f57c@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39386)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1axZKS-000872-0K
	for guix-devel@gnu.org; Tue, 03 May 2016 08:21:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1axZKG-0005FS-8x
	for guix-devel@gnu.org; Tue, 03 May 2016 08:21:22 -0400
In-Reply-To: <9b320678-3af9-22c5-ead5-23126e43f57c@gmail.com> (Manolis
	Ragkousis's message of "Sun, 1 May 2016 20:07:56 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: guix-devel@gnu.org

Manolis Ragkousis <manolis837@gmail.com> skribis:

> On 04/29/2016 06:12 PM, Jan Nieuwenhuizen wrote:
>> +  #:use-module (guix build-system trivial)
>> +  #:export (glibc
>> +            libiconv-if-needed))
>
> The #:export (glibc...) part only exists in wip-hurd so we need to
> remove this in order for your patch to apply on master.

Yes.

>> +(define-public libiconv
>> +  (package
>> +   (name "libiconv")
>> +   (version "1.14")
>> +   (source (origin
>> +            (method url-fetch)
>> +            (uri (string-append
>> +                  "mirror://gnu/libiconv/libiconv-"
>> +                  version ".tar.gz"))
>> +            (sha256
>> +             (base32
>> +              "04q6lgl3kglmmhw59igq1n7v3rp1rpkypl366cy1k1yn2znlvckj"))))
>> +   (build-system gnu-build-system)
>> +   (synopsis "Character set conversion library")
>> +   (description
>> +     "libiconv provides an implementation of the iconv function for sys=
tems
>> +that lack it.  iconv is used to convert between character encodings in a
>> +program.  It supports a wide variety of different encodings.")
>> +   (home-page "http://www.gnu.org/software/libiconv/")
>> +   (license lgpl3+)))
>
> Maybe we should break this patch into two different ones, one for the
> libiconv package description and one for the libiconv-if-needed. The
> first will go to master and the second to core-updates. WDYT?

Seconded: the patch that adds libiconv (and only that) can go directly
in master; the patch that adds =E2=80=98libiconv-if-needed=E2=80=99 must be=
 separate
since it depends on the MinGW stuff.

Thanks,
Ludo=E2=80=99.