From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: services: Add bluetooth-service.
Date: Fri, 17 Jun 2016 17:02:19 +0200
Message-ID: <87h9crvoxw.fsf@gnu.org>
References: <1466004208-4251-1-git-send-email-iyzsong@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60194)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bDvHx-000271-Pq
	for guix-devel@gnu.org; Fri, 17 Jun 2016 11:02:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bDvHr-0003pb-HV
	for guix-devel@gnu.org; Fri, 17 Jun 2016 11:02:28 -0400
In-Reply-To: <1466004208-4251-1-git-send-email-iyzsong@gmail.com>
	(=?utf-8?B?IuWui+aWh+atpiIncw==?=
	message of "Wed, 15 Jun 2016 23:23:28 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Cc: guix-devel@gnu.org

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:

> * gnu/services/desktop.scm (bluetooth-shepherd-service)
> (bluetooth-service): New Prodecures.
> (bluetooth-service-type): New variable.
> * doc/guix.text (Desktop Services): Document it.
                ^
Typo.

> +(define* (bluetooth-service #:key (bluez bluez))
> +  "Return a service that runs the @command{bluetoothd} daemon, which man=
ages
> +all the Bluetooth devices and provides a number of D-Bus interfaces.
> +
> +Users need to be in the @code{lp} group to access the D-Bus service.

I guess it=E2=80=99s not =E2=80=9Cyour fault=E2=80=9D ;-), but why is it ca=
lled =E2=80=9Clp=E2=80=9D?  That
makes me think of a printer.

Otherwise, if the issues Alex mentioned are fixed or under control, that
LGTM!

Thank you!

Ludo=E2=80=99.