From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH 2/3] profiles: Add fonts-dir-file hook.
Date: Mon, 25 Jul 2016 17:26:54 +0300
Message-ID: <87h9bdkd3l.fsf@gmail.com>
References: <20160701092730.2265-1-alezost@gmail.com>
	<20160701092730.2265-3-alezost@gmail.com> <87fursf6rf.fsf@gnu.org>
	<87lh1jalvm.fsf@gmail.com> <87r3b8w40o.fsf@gnu.org>
	<87invyrwe2.fsf@gmail.com> <87a8h7arpt.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52143)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1bRgqS-0003QF-3m
	for guix-devel@gnu.org; Mon, 25 Jul 2016 10:27:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1bRgqN-0002KK-UM
	for guix-devel@gnu.org; Mon, 25 Jul 2016 10:26:59 -0400
In-Reply-To: <87a8h7arpt.fsf@gnu.org> ("Ludovic
	\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
	\=\?utf-8\?Q\?s\?\= message of "Sun, 24 Jul 2016 19:09:02 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

Ludovic Court=C3=A8s (2016-07-24 20:09 +0300) wrote:

> Alex Kost <alezost@gmail.com> skribis:
>
>> Ludovic Court=C3=A8s (2016-07-05 17:31 +0300) wrote:
>>
>>> Alex Kost <alezost@gmail.com> skribis:
>>>
>>>> Ludovic Court=C3=A8s (2016-07-02 17:34 +0300) wrote:
>>>>
>>>>> Alex Kost <alezost@gmail.com> skribis:
>>>>>
>>>>>> * guix/profiles.scm (fonts-dir-file): New procedure.
>>>>>> (%default-profile-hooks): Add it.
>>>>>
>>>>> [...]
>>>>>
>>>>> A potential problem with this hook is that it pulls mkfontscale and
>>>>> mkfontdir regardless of whether they are needed; I can=E2=80=99t real=
ly think of
>>>>> a way to avoid it though.
>>>>
>>>> Yes, I also don't like it.  We have the same problem with
>>>> 'info-file-dir' hook: it always pulls texinfo and gzip, but not all
>>>> profiles include info manuals.
>>>
>>> Yes, but I thought it was OK to make these mandatory dependencies.
>>>
>>> The closure of mkfontscale + mkfontdir is small; it=E2=80=99s slightly =
annoying
>>> for someone building from source because you have to build a few X11
>>> libraries, but it=E2=80=99s not that much either (=E2=80=98guix graph=
=E2=80=99 shows just a few
>>> boxes.)
>>>
>>> So this hook is probably fine, after all.
>>>
>>> What do people think?
>>
>> Since there were no objections in 2 weeks, I think it's OK to commit
>> this 'fonts-dir-file' hook, right?
>
> I think so!

Committed, thanks!

--=20
Alex