From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add praat
Date: Fri, 02 Sep 2016 14:20:11 +0200
Message-ID: <87h99yo5ms.fsf@gnu.org>
References: <e154fe33-0870-8c4f-cb45-06204b664e87@openmailbox.org>
	<50962352-6623-74c9-0f33-3615daf46fcc@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47388)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bfnSF-0005RU-5K
	for guix-devel@gnu.org; Fri, 02 Sep 2016 08:20:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bfnS9-0001ZO-BA
	for guix-devel@gnu.org; Fri, 02 Sep 2016 08:20:18 -0400
In-Reply-To: <50962352-6623-74c9-0f33-3615daf46fcc@openmailbox.org> (Brendan
	Tildesley's message of "Fri, 2 Sep 2016 03:43:49 +1000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Brendan Tildesley <brendan.tildesley@openmailbox.org>
Cc: guix-devel@gnu.org

Hi Brendan,

Brendan Tildesley <brendan.tildesley@openmailbox.org> skribis:

> Please discard the first patch and consider this updated version. I was
> able to identify a timestamp and remove it, make the build reproducible.

Awesome!

> From bdc94ded90345e67885a7aa3b7e649bc546ad22c Mon Sep 17 00:00:00 2001
> From: Brendan Tildesley <brendan.tildesley@openmailbox.org>
> Date: Fri, 2 Sep 2016 03:28:58 +1000
> Subject: [PATCH] gnu: Add praat
>
> * gnu/packages/linguistics.scm (praat): New variable

[...]

> +         (add-after 'unpack 'be-timeless
> +           (lambda _
> +             (substitute* "external/portaudio/pa_front.c"
> +               ((" \\(built \" __DATE__  \" \" __TIME__ \"\\)") ""))
> +             #t))

Could you move it to a =E2=80=98snippet=E2=80=99 in the =E2=80=98origin=E2=
=80=99 form?  (See the
=E2=80=98squeak-vm=E2=80=99 package for an example.)

> +    (license (list
> +              ;; Praat it's self (no version stated =3D> gpl2+ by gpl te=
rms)
> +              ;; EEG/*, FFNet/*, LPC/* external/mp3/*
> +              ;; external/espeak/espeakdata_FileInMemory.*
> +              ;; contrib/ola/*
> +              ;; kar/ipaSerifRegularPS.cpp
> +              ;; dwsys/regularExp.h
> +              ;; dwsys/NUMmathlib.cpp
> +              license:gpl2+
> +              ;; external/gsl/*
> +              ;; external/glpk/*
> +              ;; external/espeak/*
> +              license:gpl3+
> +              ;; external/flac/*
> +              license:bsd-3
> +              ;; external/portaudio/*
> +              license:expat
> +              ;; num/NUMrandom.cpp
> +              license:public-domain
> +              ;; external/flac/flac_share_alloc.h
> +              ;; external/glpk/colamd.c
> +              license:lgpl2.1+
> +              ))))

As Alex Griffin wrote, we should remove all of external/ in =E2=80=98snippe=
t=E2=80=99
(see item #9 about =E2=80=9Cbundling=E2=80=9D at
<https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html=
>),
and instead add GSL, GLPK, FLAC, etc. as =E2=80=98inputs=E2=80=99 of the pa=
ckage.

Would you like to try it?

I think this is the only remaining blocker here.

Thank you for your work!

Ludo=E2=80=99.