From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 0/1] OpenSSL 1.1.0 Date: Mon, 05 Sep 2016 22:35:09 +0200 Message-ID: <87h99uw0ea.fsf@gnu.org> References: <87y43albe9.fsf@gnu.org> <20160902201422.GA3701@jasmine> <8737lhm6rk.fsf@gnu.org> <20160903140613.GB12802@jasmine> <87oa45jblg.fsf@gnu.org> <20160904022049.GA30856@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bh0bu-0003bZ-56 for guix-devel@gnu.org; Mon, 05 Sep 2016 16:35:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bh0bp-0003d8-Bv for guix-devel@gnu.org; Mon, 05 Sep 2016 16:35:17 -0400 In-Reply-To: <20160904022049.GA30856@jasmine> (Leo Famulari's message of "Sat, 3 Sep 2016 22:20:49 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari skribis: > From 2e6f500c7876733206e231fd98ebe7419d9b076f Mon Sep 17 00:00:00 2001 > From: Leo Famulari > Date: Fri, 2 Sep 2016 16:07:29 -0400 > Subject: [PATCH] gnu: Add openssl-next. > > * gnu/packages/tls.scm (openssl-next): New variable. > * gnu/packages/patches/openssl-1.1.0-c-rehash-in.patch: New file. > * gnu/local.mk (dist_patch_DATA): Add it. [...] > + (arguments > + `(#:disallowed-references (,perl) > + #:parallel-build? #f > + #:parallel-tests? #f > + #:test-target "test" > + > + ;; Changes to OpenSSL sometimes cause Perl to "sneak in" to the c= losure, > + ;; so we explicitly disallow it here. > + #:disallowed-references ,(list (canonical-package perl)) > + #:phases Seems like most of the arguments and phases are shared with =E2=80=98openss= l=E2=80=99, right? What about using =E2=80=98substitute-keyword-arguments=E2=80=99 to = reduce duplication? Or are you concerned about potential breakage when one series or the other changes? (arguments (substitute-keyword-arguments (package-arguments openssl) ((#:phase phases) `(modify-phases ,phases (add-after 'something 'some-openssl-1.1-specific-phase =E2=80=A6))= ))) Thanks! Ludo=E2=80=99.