all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 0/1] OpenSSL 1.1.0
Date: Mon, 05 Sep 2016 22:35:09 +0200	[thread overview]
Message-ID: <87h99uw0ea.fsf@gnu.org> (raw)
In-Reply-To: <20160904022049.GA30856@jasmine> (Leo Famulari's message of "Sat, 3 Sep 2016 22:20:49 -0400")

Leo Famulari <leo@famulari.name> skribis:

> From 2e6f500c7876733206e231fd98ebe7419d9b076f Mon Sep 17 00:00:00 2001
> From: Leo Famulari <leo@famulari.name>
> Date: Fri, 2 Sep 2016 16:07:29 -0400
> Subject: [PATCH] gnu: Add openssl-next.
>
> * gnu/packages/tls.scm (openssl-next): New variable.
> * gnu/packages/patches/openssl-1.1.0-c-rehash-in.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.

[...]

> +    (arguments
> +     `(#:disallowed-references (,perl)
> +       #:parallel-build? #f
> +       #:parallel-tests? #f
> +       #:test-target "test"
> +
> +       ;; Changes to OpenSSL sometimes cause Perl to "sneak in" to the closure,
> +       ;; so we explicitly disallow it here.
> +       #:disallowed-references ,(list (canonical-package perl))
> +       #:phases

Seems like most of the arguments and phases are shared with ‘openssl’,
right?  What about using ‘substitute-keyword-arguments’ to reduce
duplication?  Or are you concerned about potential breakage when one
series or the other changes?

  (arguments
   (substitute-keyword-arguments (package-arguments openssl)
     ((#:phase phases)
      `(modify-phases ,phases
         (add-after 'something 'some-openssl-1.1-specific-phase …)))))

Thanks!

Ludo’.

  parent reply	other threads:[~2016-09-05 20:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-02  1:59 [PATCH 0/1] OpenSSL 1.1.0 Leo Famulari
2016-09-02  1:59 ` [PATCH 1/1] gnu: openssl: Update to 1.1.0 Leo Famulari
2016-09-02  7:40 ` [PATCH 0/1] OpenSSL 1.1.0 Ricardo Wurmus
2016-09-02 12:43   ` Ludovic Courtès
2016-09-02 20:14     ` Leo Famulari
2016-09-02 20:30       ` Leo Famulari
2016-09-03 13:50       ` Ludovic Courtès
2016-09-03 14:06         ` Leo Famulari
2016-09-03 14:34           ` Ludovic Courtès
2016-09-04  2:20             ` Leo Famulari
2016-09-04  2:48               ` Leo Famulari
2016-09-05 20:35               ` Ludovic Courtès [this message]
2016-09-05 23:05                 ` Leo Famulari
2016-09-06 12:29                   ` Ludovic Courtès
2016-09-06 17:47                     ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h99uw0ea.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.