From: ludo@gnu.org (Ludovic Courtès)
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/3] gnu: vlc: Add configure flags.
Date: Sat, 24 Sep 2016 13:18:34 +0900 [thread overview]
Message-ID: <87h996rkv9.fsf@gnu.org> (raw)
In-Reply-To: <20160920200805.GA20679@jasmine> (Leo Famulari's message of "Tue, 20 Sep 2016 16:08:05 -0400")
Leo Famulari <leo@famulari.name> skribis:
> On Sat, Sep 10, 2016 at 11:07:29AM +0800, Alex Vong wrote:
>> From 066bee5d7795c6caf2376be4a38e2cf0b397ef98 Mon Sep 17 00:00:00 2001
>> From: Alex Vong <alexvong1995@gmail.com>
>> Date: Sat, 10 Sep 2016 00:32:03 +0800
>> Subject: [PATCH 2/3] gnu: vlc: Add configure flags.
>>
>> * gnu/packages/video.scm (vlc)[arguments]: Add configure flags to enable
>> most fast-math optimizations.
>> ---
>> gnu/packages/video.scm | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
>> index 858e007..a041666 100644
>> --- a/gnu/packages/video.scm
>> +++ b/gnu/packages/video.scm
>> @@ -650,7 +650,10 @@ audio/video codec library.")
>> `(;; Gross workaround for <https://trac.videolan.org/vlc/ticket/16907>.
>> ;; In our case, this led to a test failure:
>> ;; test_libvlc_equalizer: libvlc/equalizer.c:122: test_equalizer: Assertion `isnan(libvlc_audio_equalizer_get_amp_at_index (equalizer, u_bands))' failed.
>> + ;; FIXME: This bug is fixed upstream. For now, we enable:
>> "ac_cv_c_fast_math=no"
>> + "CFLAGS=-ffast-math -fno-finite-math-only"
>> + "CXXFLAGS=-ffast-math -fno-finite-math-only"
>
> I don't know much about this subject. Can anyone say if we can expect
> this to work on all our supported architectures?
Dunno; Alex, could you tell more? :-) Also, didn’t you mean to remove
the ac_cv_c_fast_math=no line altogether?
Ludo’.
prev parent reply other threads:[~2016-09-24 5:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-10 3:07 [PATCH 2/3] gnu: vlc: Add configure flags Alex Vong
2016-09-20 20:08 ` Leo Famulari
2016-09-24 4:18 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h996rkv9.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.