From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [Patch 3/10] Add gsm.
Date: Wed, 28 Sep 2016 11:16:02 +0200
Message-ID: <87h9904c6l.fsf@gnu.org>
References: <87mvjc1quq.fsf@openmailbox.org> <877fag1qpb.fsf@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51296)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bpAyI-0001z1-I1
	for guix-devel@gnu.org; Wed, 28 Sep 2016 05:16:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bpAyF-0004Tu-Ax
	for guix-devel@gnu.org; Wed, 28 Sep 2016 05:16:10 -0400
In-Reply-To: <877fag1qpb.fsf@openmailbox.org> (Lukas Gradl's message of "Mon,
	12 Sep 2016 21:25:20 -0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Lukas Gradl <lgradl@openmailbox.org>
Cc: guix-devel@gnu.org

Lukas Gradl <lgradl@openmailbox.org> skribis:

> From ecafdf21a654c97fa9adb2c382c431c297a3fee0 Mon Sep 17 00:00:00 2001
> From: Lukas Gradl <lgradl@openmailbox.org>
> Date: Tue, 9 Aug 2016 16:43:36 -0500
> Subject: [PATCH 03/10] gnu: Add gsm.
>
> * gnu/packages/audio.scm (gsm): New variable.

Applied with small changes:

> +             (let ((out (assoc-ref %outputs "out")))
> +               (begin
> +                (system* "mv" (string-append out "/inc")
> +                         (string-append out "/include"))

I removed =E2=80=98begin=E2=80=99 and used =E2=80=98rename-file=E2=80=99 he=
re.

> +                (mkdir-p (string-append out "/include/gsm"))
> +                (copy-recursively
> +                 "inc" (string-append out "/include/gsm"))))))

I noticed that this leads to a situation where we have both
include/gsm.h and include/gsm/gsm.h as identical file.  I suppose the
former is unnecessary?

Thanks!

Ludo=E2=80=99.