* [PATCH] import: utils: Remove dependency on (json) module.
@ 2016-10-15 16:53 Alex Kost
2016-10-16 10:29 ` Ricardo Wurmus
0 siblings, 1 reply; 3+ messages in thread
From: Alex Kost @ 2016-10-15 16:53 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 166 bytes --]
Commit fbe9c1012820 introduced unneeded dependency on (json) module,
i.e. 'guile-json' is a hard dependency of Guix now.
Was it an accident, or do I miss anything?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-import-utils-Remove-dependency-on-json-module.patch --]
[-- Type: text/x-patch, Size: 766 bytes --]
From cb529053b90cd4067fb6cb9a256b1ce3bd2a24f7 Mon Sep 17 00:00:00 2001
From: Alex Kost <alezost@gmail.com>
Date: Sat, 15 Oct 2016 19:41:35 +0300
Subject: [PATCH] import: utils: Remove dependency on (json) module.
This fixes a regression introduced by commit
fbe9c1012820ab72f022a6ec958c35b431ae7a74.
* guix/import/utils.scm: Remove unused (json) module.
---
guix/import/utils.scm | 1 -
1 file changed, 1 deletion(-)
diff --git a/guix/import/utils.scm b/guix/import/utils.scm
index e4059ca..057c2d9 100644
--- a/guix/import/utils.scm
+++ b/guix/import/utils.scm
@@ -26,7 +26,6 @@
#:use-module (guix utils)
#:use-module (ice-9 match)
#:use-module (ice-9 regex)
- #:use-module (json)
#:use-module (srfi srfi-1)
#:export (factorize-uri
--
2.9.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] import: utils: Remove dependency on (json) module.
2016-10-15 16:53 [PATCH] import: utils: Remove dependency on (json) module Alex Kost
@ 2016-10-16 10:29 ` Ricardo Wurmus
2016-10-16 16:23 ` Alex Kost
0 siblings, 1 reply; 3+ messages in thread
From: Ricardo Wurmus @ 2016-10-16 10:29 UTC (permalink / raw)
To: Alex Kost; +Cc: guix-devel
Alex Kost <alezost@gmail.com> writes:
> Commit fbe9c1012820 introduced unneeded dependency on (json) module,
> i.e. 'guile-json' is a hard dependency of Guix now.
>
> Was it an accident, or do I miss anything?
I think this was an accident. We always tried to keep guile-json as a
soft dependency in the past and I don’t recall any decision about making
it a hard dependency.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] import: utils: Remove dependency on (json) module.
2016-10-16 10:29 ` Ricardo Wurmus
@ 2016-10-16 16:23 ` Alex Kost
0 siblings, 0 replies; 3+ messages in thread
From: Alex Kost @ 2016-10-16 16:23 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: guix-devel
Ricardo Wurmus (2016-10-16 12:29 +0200) wrote:
> Alex Kost <alezost@gmail.com> writes:
>
>> Commit fbe9c1012820 introduced unneeded dependency on (json) module,
>> i.e. 'guile-json' is a hard dependency of Guix now.
>>
>> Was it an accident, or do I miss anything?
>
> I think this was an accident. We always tried to keep guile-json as a
> soft dependency in the past and I don’t recall any decision about making
> it a hard dependency.
Right, that's what I thought, David also confirmed it (he probably
forgot to CC guix-devel), so I've committed this patch, thanks.
--
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-16 16:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-15 16:53 [PATCH] import: utils: Remove dependency on (json) module Alex Kost
2016-10-16 10:29 ` Ricardo Wurmus
2016-10-16 16:23 ` Alex Kost
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.