Ludovic Courtès <ludo@gnu.org> writes:

> Marius Bakke <mbakke@fastmail.com> skribis:
>
>> Some failures are indeed due to missing network or programs in the build
>> environment. I tried patching a few just now, but unfortunately some
>> files are in a format apparently not supported by Guile!
>>
>>  870: 5 [call-with-input-file "ext/mbstring/tests/bug26639.phpt" ...]
>> In /gnu/store/ciqw5z470c8ihl1kfswj1j3ix6hs092d-module-import/guix/build/utils.scm:
>>  556: 4 [#<procedure 16a6440 at /gnu/store/ciqw5z470c8ihl1kfswj1j3ix6hs092d-module-import/guix/buil
>> d/utils.scm:555:10 (in)> #<input: ext/mbstring/tests/bug26639.phpt 11>]
>>  592: 3 [#<procedure 1798aa0 at /gnu/store/ciqw5z470c8ihl1kfswj1j3ix6hs092d-module-import/guix/buil
>> d/utils.scm:578:6 (in out)> #<input: ext/mbstring/tests/bug26639.phpt 11> ...]
>> In ice-9/rdelim.scm:
>>  188: 2 [read-line #<input: ext/mbstring/tests/bug26639.phpt 11> concat]
>> In unknown file:
>>    ?: 1 [%read-line #<input: ext/mbstring/tests/bug26639.phpt 11>]
>> In ice-9/boot-9.scm:
>>  109: 0 [#<procedure 16a6480 at ice-9/boot-9.scm:100:6 (thrown-k . args)> decoding-error ...]
>>
>> ice-9/boot-9.scm:109:20: In procedure #<procedure 16a6480 at ice-9/boot-9.scm:100:6 (thrown-k . arg
>> s)>:
>> ice-9/boot-9.scm:109:20: Throw to key `decoding-error' with args `("scm_getc" "input decoding error
>> " 84 #<input: ext/mbstring/tests/bug26639.phpt 11>)'.
>>
>> `file` reports: ext/mbstring/tests/bug26639.phpt: Non-ISO extended-ASCII text
>
> Presumably this is ‘substitute*’ failing to read the file.
>
> ‘substitute*’ expects input files to be UTF-8-encoded; when this is not
> the case, you need to bind ‘%default-port-encoding’ to whatever is the
> right encoding or #f for the catch-all ISO-8859-1.  See
> ‘gettext-minimal’ for an example.

Thank you! That was exactly what I needed.

Unfortunately that only fixed a handful of tests, the remaining
50-something had to be disabled for a variety of reasons.

I've added a commentary to each disabled test. If you recognize any of
these errors/think you know what's going on, please update the patch.
It would be nice to know if the iconv and gd stuff is expected, and if
the two sqlite tests can really be ignored. The curl one is strange too.

If there are no further comments, I will push this in the next few days: