From: ludo@gnu.org (Ludovic Courtès)
To: Petter <petter@mykolab.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Remove redundancy where mkdir-p <dir> is followed by install-file <file> <dir>.
Date: Mon, 21 Nov 2016 15:22:07 +0100 [thread overview]
Message-ID: <87h970vrow.fsf@gnu.org> (raw)
In-Reply-To: <5cf95ba2b20f58e0bfa9392ea0eb92cf@mykolab.ch> (petter@mykolab.ch's message of "Sun, 20 Nov 2016 16:28:29 +0100")
Hi Petter,
Sounds like a good idea.
Petter <petter@mykolab.ch> skribis:
> From 595d438789c7c9a293ae7fac500ace7422073624 Mon Sep 17 00:00:00 2001
> From: Petter <petter@mykolab.ch>
> Date: Sun, 20 Nov 2016 13:39:13 +0100
> Subject: [PATCH] gnu: Remove redundancy where mkdir-p <dir> is followed by
> install-file <file> <dir>.
>
> * gnu/packages/bioinformatics.scm (bwa)[source]: Remove redundant mkdir-p.
> * gnu/packages/bioinformatics.scm (eigensoft)[source]: Likewise.
> * gnu/packages/bioinformatics.scm (snap-aligner)[source]: Likewise.
> * gnu/packages/bioinformatics.scm (pardre)[source]: Likewise.
> * gnu/packages/bioinformatics.scm (piranha)[source]: Likewise.
Nitpick: no need to repeat the file name for each entry here.
> * gnu/packages/maths.scm (hypre)[source]: Likewise.
> * gnu/packages/mp3.scm (mpc123)[source]: Likewise.
> * gnu/packages/music.scm (tuxguitar)[source]: Likewise.
> * gnu/packages/pdf.scm (impressive)[source]: Likewise.
> * gnu/packages/qemu.scm (qemu)[source]: Likewise.
> * gnu/packages/tls.scm (openssl)[source]: Likewise.
The only question here before we can apply is how much gets rebuilt as a
consequence of this change.
Changing openssl would rebuild too much for instance, so that would go
to the ‘core-updates’ branch.
The rest looks OK for master, but could you check with ‘guix refresh -l’
and submit separate patches accordingly? See
<https://lists.gnu.org/archive/html/guix-devel/2016-10/msg00933.html>
on how to choose a branch.
Thank you!
Ludo’.
next prev parent reply other threads:[~2016-11-21 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-20 15:28 [PATCH] gnu: Remove redundancy where mkdir-p <dir> is followed by install-file <file> <dir> Petter
2016-11-20 17:05 ` Leo Famulari
2016-11-21 19:06 ` Petter
2016-11-21 19:43 ` Leo Famulari
2016-11-21 14:22 ` Ludovic Courtès [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-11-20 15:25 Petter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h970vrow.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=petter@mykolab.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.