From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 02/10] gnu: Add propeller-binutils.
Date: Sat, 31 Dec 2016 01:31:36 +0100
Message-ID: <87h95l547r.fsf@gnu.org>
References: <20161226160452.19939-1-rekado@elephly.net>
	<20161226160452.19939-2-rekado@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49473)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cN7aH-0003bP-P6
	for guix-devel@gnu.org; Fri, 30 Dec 2016 19:31:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cN7aE-00040H-Mq
	for guix-devel@gnu.org; Fri, 30 Dec 2016 19:31:41 -0500
In-Reply-To: <20161226160452.19939-2-rekado@elephly.net> (Ricardo Wurmus's
	message of "Mon, 26 Dec 2016 17:04:44 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org

Ricardo Wurmus <rekado@elephly.net> skribis:

> * gnu/packages/embedded.scm (propeller-binutils): New variable.

[...]

> +         ,@(substitute-keyword-arguments (package-arguments xbinutils)
> +             ((#:configure-flags flags)
> +              `(cons "--disable-nls" ,flags)))))

That shouldn't be needed.

> +      (native-inputs
> +       `(("bison" ,bison)
> +         ("flex" ,flex)
> +         ("texinfo" ,texinfo)
> +         ("dejagnu" ,dejagnu)

The test failures you see are because you added DejaGNU here.  The other
Binutils instances don=E2=80=99t have it, so few tests are run I guess.  :-)

If this is not needed for bootstrapping, I=E2=80=99d suggest removing it.

Otherwise LGTM, thanks!