From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: Cuirass and duplicate derivations
Date: Mon, 09 Jan 2017 10:11:54 +0100
Message-ID: <87h958r411.fsf@gnu.org>
References: <87r35o8x0h.fsf@gnu.org> <87shq35tue.fsf@gnu.org>
	<87y3zv4c4i.fsf@gnu.org> <87fuljj5ku.fsf@gnu.org>
	<87tw9mzq4v.fsf@gnu.org> <87eg0l9m38.fsf_-_@gnu.org>
	<87tw99yw8l.fsf@gnu.org> <87a8b1xdx5.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52183)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cQVzq-0003I4-9j
	for guix-devel@gnu.org; Mon, 09 Jan 2017 04:12:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cQVzp-00006G-7Q
	for guix-devel@gnu.org; Mon, 09 Jan 2017 04:12:06 -0500
In-Reply-To: <87a8b1xdx5.fsf@gnu.org> (Mathieu Lirzin's message of "Mon, 09
	Jan 2017 01:41:42 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Mathieu Lirzin <mthl@gnu.org>
Cc: guix-devel@gnu.org

Hello,

Mathieu Lirzin <mthl@gnu.org> skribis:

> Mathieu Lirzin <mthl@gnu.org> writes:
>
>> ludo@gnu.org (Ludovic Court=C3=A8s) writes:
>>
>>> What change would you suggest to solve this problem?  It would be best
>>> if Cuirass allowed several jobs building the same derivations (the key
>>> could be an autoincrement counter instead of the (drv,eval) pair maybe?)
>>
>> Seems reasonable to me.  I will do that.
>> Thanks.
>
> After a second thought, I think maybe it is sufficient to just ignore
> when a derivation is added twice by an evaluation.  As a consequence
> 'cuirass' will only try to realize the derivation once per evaluation.

Even better, yes.

> From 568d0e1b0866a45e95440d17b6e8f1740cc23e3f Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mthl@gnu.org>
> Date: Mon, 9 Jan 2017 01:29:48 +0100
> Subject: [PATCH] database: db-add-derivation: Don't try to add a derivati=
on
>  twice.
>
> * src/cuirass/database.scm (db-add-derivation): Ignore if JOB is already
> present in DB.

OK!

We can update the =E2=80=98cuirass=E2=80=99 package in Guix afterwards.

Thank you!

Ludo=E2=80=99.