From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marius Bakke <mbakke@fastmail.com>
Subject: Re: [PATCH] gnu: Add python-pyodbc-c.
Date: Thu, 26 Jan 2017 19:14:41 +0100
Message-ID: <87h94l4rji.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
References: <20170126002621.9247-1-dannym@scratchpost.org>
	<87mvedkbgw.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54932)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mbakke@fastmail.com>) id 1cWoZO-0002bT-2v
	for guix-devel@gnu.org; Thu, 26 Jan 2017 13:14:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mbakke@fastmail.com>) id 1cWoZJ-0007O2-Qe
	for guix-devel@gnu.org; Thu, 26 Jan 2017 13:14:50 -0500
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:36262)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mbakke@fastmail.com>) id 1cWoZJ-0007Ns-Jl
	for guix-devel@gnu.org; Thu, 26 Jan 2017 13:14:45 -0500
In-Reply-To: <87mvedkbgw.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: ng0 <contact.ng0@cryptolab.net>, Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

ng0 <contact.ng0@cryptolab.net> writes:

> Danny Milosavljevic <dannym@scratchpost.org> writes:
>
>> * gnu/packages/databases.scm (python-pyodbc-c, python2-pyodbc-c):
>>   New variables.

[...]

>> +       (file-name (string-append name "-" version ".tar.gz"))))
>> +    (build-system python-build-system)
>> +    (inputs
>> +     `(("unixodbc" ,unixodbc)))
>> +    (arguments
>> +     `(#:tests? #f ; no tests exist
>> +      ))

Please move these to the previous line.

>> +    (home-page "https://github.com/mkleehammer/pyodbc")
>
> This is pulled from gitlab and the homepage is on gitlab? I think
> it's better to use the gitlab repository as home-page then, or
> what's the reason?

I think this is a better home page since it provides usage instructions:

https://mkleehammer.github.io/pyodbc/
>
>> +    (synopsis "Python ODBC Library")
>> +    (description "This package provides a Python DB-API driver for ODBC=
.")
>
> If I remember correctly, we should avoid starting synopsis and
> description with words like "This". What about:
>
> (description "@code{python-pyodbc-c} provides =E2=80=A6"

Either of these two styles are fine IMO. LGTM!

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAliKPJEACgkQoqBt8qM6
VPpuKQf/ZjAgKrPC8NR0GZVrYd2yGr3Gz4eXhZd3Jwz765IFhbTAf05Bsj43NZZG
s3BfjmHokxs6XgciihkXOu0xKqnqoMXdOP/d2jRI8/wjdH51/ekvBTu8H6siWHVO
2aFAEd6SsV272zhowQf3agpyJR+2D7nnTWUcq/P1iorgAzexkyWwvDWEwNmhE+V+
igiSFQoIs/qR1Mb9fQRpLBZ36GbSmp9mmtpaibNAQ5eenkhrFSaQoiIZBrA+aT5Q
0TgojkwuDXNESC8VKHyy68uqJNZDxLnSy28dd0O1wXEeo9pCdlVZRECmYMwQUbEv
m3zSceIjlx9MLZ5pQPVqwAC1IIetNw==
=suvv
-----END PGP SIGNATURE-----
--=-=-=--