From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 09/10] gnu: Add ocaml-js-build-tools.
Date: Mon, 30 Jan 2017 23:23:27 +0100
Message-ID: <87h94gkx0g.fsf@gnu.org>
References: <20170127221228.4370-1-julien@lepiller.eu>
	<20170127221228.4370-10-julien@lepiller.eu> <87inowgawq.fsf@gnu.org>
	<20170130220850.77b8e4a4@lepiller.eu>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47147)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cYKMH-0007RE-QN
	for guix-devel@gnu.org; Mon, 30 Jan 2017 17:23:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cYKME-0001H3-KR
	for guix-devel@gnu.org; Mon, 30 Jan 2017 17:23:33 -0500
In-Reply-To: <20170130220850.77b8e4a4@lepiller.eu> (Julien Lepiller's message
	of "Mon, 30 Jan 2017 22:08:50 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: guix-devel <guix-devel@gnu.org>

Julien Lepiller <julien@lepiller.eu> skribis:

> On Mon, 30 Jan 2017 10:22:13 +0100
> ludo@gnu.org (Ludovic Court=C3=A8s) wrote:
>
>> Julien Lepiller <julien@lepiller.eu> skribis:
>>=20
>> > +++ b/gnu/packages/patches/ocaml-janestreet-fix-libdir.patch
>> > @@ -0,0 +1,39 @@
>> > +This patch adds a --libdir option to opam-installer so it installs
>> > the plugin +in the specified directory rather than in the default
>> > one (ocaml's directory in +the store, which is forbidden).
>> > +diff -aur package.pristine/Makefile package.new/Makefile
>> > +--- package.pristine/Makefile	2016-02-06 01:55:14.650150309
>> > +0100 ++++ package.new/Makefile	2016-02-06
>> > 01:57:56.012174364 +0100 +@@ -29,26 +29,26 @@
>> > + 	ocaml -I js-utils js-utils/gen_install.ml
>> > +
>> > + install: $(NAME).install
>> > +-	opam-installer -i --prefix $(PREFIX) $(NAME).install
>> > ++	opam-installer -i --prefix $(PREFIX) --libdir $(LIBDIR)
>> > $(NAME).install +
>> > + uninstall: $(NAME).install
>> > +-	opam-installer -u --prefix $(PREFIX) $(NAME).install
>> > ++	opam-installer -u --prefix $(PREFIX) --libdir $(LIBDIR)
>> > $(NAME).install=20=20
>>=20
>> On second thought, I think it=E2=80=99d be simpler and more maintainable=
 to do
>> this as a substitution in the snippet.
>>=20
>> WDYT?
>>=20
>> (It will also avoid =E2=80=98guix lint=E2=80=99 complaints about the pat=
ch file name
>> not matching the package name.  :-))
>>=20
>> Ludo=E2=80=99.
>
> Sure, here it is :)
>
> From 8cd3ba3a3f9702a89f8f52c75c33d3d02f20f60b Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Fri, 30 Dec 2016 16:27:27 +0100
> Subject: [PATCH 2/2] gnu: Add ocaml-bin-prot.
>
> * gnu/packages/ocaml.scm (ocaml-bin-prot): New variable.

Wait, I was commenting on ocaml-js-build-tools, not on ocaml-bin-prot:

  https://lists.gnu.org/archive/html/guix-devel/2017-01/threads.html#02134

Could it be that you=E2=80=99re replying to the wrong message?  :-)

Ludo=E2=80=99.