From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: 01/01: gnu: grub-efi: Really build the EFI variant.
Date: Wed, 08 Feb 2017 12:24:40 +0100
Message-ID: <87h945q613.fsf@gnu.org>
References: <20170207101551.13623.62644@vcs.savannah.gnu.org>
	<20170207101551.F0842220055@vcs.savannah.gnu.org>
	<877f52ht1o.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59015)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cbQMg-0003Tz-Ad
	for guix-devel@gnu.org; Wed, 08 Feb 2017 06:24:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cbQMd-0003ZR-7E
	for guix-devel@gnu.org; Wed, 08 Feb 2017 06:24:46 -0500
In-Reply-To: <877f52ht1o.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
	(Marius Bakke's message of "Tue, 07 Feb 2017 17:20:03 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org

Marius Bakke <mbakke@fastmail.com> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> civodul pushed a commit to branch master
>> in repository guix.
>>
>> commit ef753a1a8f9e7c971957abfda9b672a7728cd073
>> Author: Ludovic Court=C3=A8s <ludo@gnu.org>
>> Date:   Tue Feb 7 11:14:09 2017 +0100
>>
>>     gnu: grub-efi: Really build the EFI variant.
>>=20=20=20=20=20
>>     Fixes a regression introduced in
>>     d846834fc2b2f76aa2e258685bc211edd31866c5 where '--with-platform=3Def=
i'
>>     would no longer be passed.
>>=20=20=20=20=20
>>     * gnu/packages/grub.scm (grub-efi)[arguments]: Provide a default val=
ue
>>     for #:configure-flags.
>
> [...]
>
>> @@ -139,8 +139,8 @@ menu to select one of the installed operating system=
s.")
>>         ;; Search for 'OVMF' in "tests/util/grub-shell.in".
>>         #:tests? #f
>>         ,@(substitute-keyword-arguments (package-arguments grub)
>> -           ((#:configure-flags flags) `(cons* "--with-platform=3Defi"
>> -                                              ,flags))
>> +           ((#:configure-flags flags ''())
>> +            `(cons "--with-platform=3Defi" ,flags))
>>             ((#:phases phases)
>>              `(modify-phases ,phases
>>                 (add-after 'patch-stuff 'use-absolute-efibootmgr-path
>
> Thank you for this! I did test grub-efi with the new grub release, but
> then afterwards checked whether the #:configure-flags were still needed.
>
> I will be more careful about this in the future.

No problem, it=E2=80=99s easy to get tripped up with things that inherit and
customize flags.

Ludo=E2=80=99.