From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Huang\, Ying" Subject: Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build Date: Sat, 25 Feb 2017 09:05:59 +0800 Message-ID: <87h93j9j0o.fsf@163.com> References: <20170218004427.12392-1-huang_ying_caritas@163.com> <87tw7jn4mo.fsf@163.com> <20170224150256.641cb08d@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1chQoU-00085t-7O for guix-devel@gnu.org; Fri, 24 Feb 2017 20:06:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1chQoP-000108-8n for guix-devel@gnu.org; Fri, 24 Feb 2017 20:06:18 -0500 Received: from m12-11.163.com ([220.181.12.11]:48708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1chQoO-0000y4-Fv for guix-devel@gnu.org; Fri, 24 Feb 2017 20:06:13 -0500 In-Reply-To: <20170224150256.641cb08d@scratchpost.org> (Danny Milosavljevic's message of "Fri, 24 Feb 2017 15:02:56 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic Cc: guix-devel@gnu.org, Alex Kost Danny Milosavljevic writes: > Hi, > > yeah, I've looked at it and I see what you are trying to do. > > You modified 'union to replicate the directory tree and symlink only the non-directory files - in order to be able to add "fonts.dir" in those directories. > > The previous version symlinked entire directories, too, and you wouldn't have been able to add those "fonts.dir" files inside them later. > > Your fix seems kinda hacky - but I don't really see a downside. > > Thinking about it some more I think it looks good enough to me. I'd like a second opinion, though. > > Other than that, the name of the new flag "create-all-directory?" is weird. I'd like it to be something like "create-all-directories?". OK. Will change it. Best Regards, Huang, Ying > (The non-hacky solution would be to make 'union aware that there are > "fonts.dir" files to go in there, too. One could do that by adding > these as an input, too. I'm not sure whether that would be worth the > added complexity, though - especially since the fonts.dir generator > needs to have the finished union as input and not just single > directories one by one. Thoughts?)