From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 4/4] services: openssh: Add 'subsystems' option. Date: Thu, 16 Mar 2017 11:03:27 +0100 Message-ID: <87h92t1qts.fsf@gnu.org> References: <20170219185431.zgn53ndcbpedrgo7@wasp> <20170220235355.29115-1-clement@lassieur.org> <20170220235355.29115-5-clement@lassieur.org> <20170302084448.2ff6ce96@scratchpost.org> <87fuivxukg.fsf@lassieur.org> <20170305145026.zgoayn46kvpz5ksy@abyayala> <20170307214959.16038114@scratchpost.org> <87r3284x8s.fsf@lassieur.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1coSFp-0007Ev-Dl for guix-devel@gnu.org; Thu, 16 Mar 2017 06:03:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1coSFm-0001ty-A4 for guix-devel@gnu.org; Thu, 16 Mar 2017 06:03:33 -0400 In-Reply-To: <87r3284x8s.fsf@lassieur.org> (=?utf-8?Q?=22Cl=C3=A9ment?= Lassieur"'s message of "Tue, 07 Mar 2017 22:01:39 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur Cc: guix-devel@gnu.org Hi Cl=C3=A9ment, Cl=C3=A9ment Lassieur skribis: > I think there is a misunderstanding. I didn't want to push this because > it was not tested, and because subsystems are often useless without > Match, and Match is unsupported. The pair/list thing is not the > problem. > > And I was waiting for ng0 to test, because he asked for this patch (see > http://lists.gnu.org/archive/html/guix-devel/2017-02/msg00906.html), so > I thought he was able to test. > > If ng0 still needs the patch and confirms that it works well, I'm > willing to update it. Otherwise, let's drop it. The patch looks like a useful addition. It would be sad to drop it, no? If you could add a test to (gnu tests ssh) that would be perfect, but otherwise it LGTM. Perhaps the default value for =E2=80=98subsystems=E2=80= =99 should include internal-sftp though, as users probably expect sftp to just work. I don=E2=80=99t have any issue with using two-element lists; I think the sy= ntax for pairs can be a bit confusing for newcomers to it=E2=80=99s probably bet= ter to avoid it in service configuration. Thanks, Ludo=E2=80=99.