From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] Add neofetch to games.scm doubleplusgood23@gmail.com Date: Mon, 08 May 2017 20:27:07 +0300 Message-ID: <87h90vmf84.fsf@gmail.com> References: <87mvaq4ts4.fsf@iori.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7mRG-0006a4-LW for guix-devel@gnu.org; Mon, 08 May 2017 13:27:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7mRD-0001Mt-ES for guix-devel@gnu.org; Mon, 08 May 2017 13:27:14 -0400 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:35829) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d7mRD-0001MZ-8n for guix-devel@gnu.org; Mon, 08 May 2017 13:27:11 -0400 Received: by mail-wm0-x244.google.com with SMTP id v4so12068848wmb.2 for ; Mon, 08 May 2017 10:27:11 -0700 (PDT) In-Reply-To: <87mvaq4ts4.fsf@iori.i-did-not-set--mail-host-address--so-tickle-me> (doubleplusgood's message of "Fri, 05 May 2017 22:13:15 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: doubleplusgood23@gmail.com Cc: guix-devel@gnu.org doubleplusgood23@gmail.com (2017-05-05 22:13 -0400) wrote: > Pretty small patch for my first time commiting. Hello and welcome! I also have a couple of notes additionally to what Arun wrote. > From ff50a931905376440f245c37df620d724a78dde9 Mon Sep 17 00:00:00 2001 > From: "Ethan R. Jones" > Date: Fri, 5 May 2017 22:02:48 -0400 > Subject: [PATCH] Adding neofetch to the games package expression. > > --- > gnu/packages/games.scm | 35 +++++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm > index b31bb93db..b0831b4a0 100644 > --- a/gnu/packages/games.scm > +++ b/gnu/packages/games.scm > @@ -28,6 +28,7 @@ > ;;; Copyright =C2=A9 2017 Arun Isaac > ;;; Copyright =C2=A9 2017 Tobias Geerinckx-Rice > ;;; Copyright =C2=A9 2017 nee > +;;; Copyright =C2=A9 2017 Ethan "dpg" Jones > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -3941,3 +3942,37 @@ fabulous Orb of Zot.") > license:expat > license:zlib > license:asl2.0)))) > + > +(define-public neofetch > + (package > + (name "neofetch") > + (version "3.1.0") > + (source (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/dylanaraps/neofetch.git") > + (commit version))) We usually use 'url-fetch' with a tarball snapshot (not sure if there is a preference though): https://github.com/dylanaraps/neofetch/archive/3.1.0.tar.gz > + (file-name (string-append name "-" version)) > + (sha256 > + (base32 > + "0z2ch1j9m5xsdaqn89dd7xlick67jfqpa90mb4djyycgak9751ca"))= )) > + (build-system gnu-build-system) > + (arguments > + '(#:tests? #f ;; Because neofetch is a bash script it only needs ma= ke install. > + #:strip-binaries? #f > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) > + (delete 'build)) > + #:make-flags ;; We need to the Makefile to output to our proper = store. > + (list (string-append "DESTDIR=3D" %output)))) > + (inputs `(("bash" ,bash))) ;; Only requires bash! > + (synopsis "System info script") > + (description "Neofetch is a CLI system information tool written in > +BASH. Neofetch displays information about your system next to an image,= your OS > +logo, or any ASCII file of your choice. The main purpose of Neofetch is > +to be used in screenshots to show other users what OS/Distro you're > +running, what Theme/Icons you're using etc. ") ^^ Please remove those spaces. > + (home-page "https://github.com/dylanaraps/neofetch") > + (license license:expat))) --=20 Alex