From: Marius Bakke <mbakke@fastmail.com>
To: "Danny Milosavljevic" <dannym@scratchpost.org>, 宋文武 <iyzsong@gmail.com>
Cc: 26988@debbugs.gnu.org
Subject: bug#26988: Add desktop-file-utils to all gtk applications
Date: Sun, 21 May 2017 01:00:22 +0200 [thread overview]
Message-ID: <87h90f5e2h.fsf@fastmail.com> (raw)
In-Reply-To: <20170520150411.21c3e0aa@scratchpost.org>
[-- Attachment #1: Type: text/plain, Size: 3302 bytes --]
Danny Milosavljevic <dannym@scratchpost.org> writes:
> Hi Marius,
> Hi 宋文武,
>
> On Sat, 20 May 2017 01:05:22 +0200
> Marius Bakke <mbakke@fastmail.com> wrote:
>
>> Danny Milosavljevic <dannym@scratchpost.org> writes:
>>
>> > these are two patches I propose we add in order to add
>> > desktop-file-utils to all gtk applications. This means that the
>> > profile hook would pick up the desktop files (as soon as possible).
>>
>> So if I read (guix profiles) correctly, the hook only runs when
>> 'desktop-file-utils' is referenced. Would checking for a gtk reference
>> as well not achieve the same effect? Or is that too expensive?
>
> That would probably work as well.
>
> But the idea is KDE would eventually use the XDG desktop cache, too (maybe it already does - no idea). Any other desktop environments that don't reinvent the wheel in that regard would use desktop-file-utils as well - and that's the package that actually contains the "update-desktop-database" executable for updating the XDG desktop cache.
>
> Right now the "xdg-desktop-database" profile hook doesn't need its own magical packages but it just uses the existing desktop-file-utils reference for actually updating the desktop database.
IIUC, the idea is to run the hook every time a package with a ".desktop"
file has changed. Even if we propagate "desktop-file-utils" from say,
GTK+ and Qt, it won't catch some cases where we add the ".desktop" file
manually such as "rxvt-unicode".
I wonder if there is a more generic thing we could test for.. Maybe
libx11? Obviously lots of false positives, but the hook is not *that*
expensive. Thoughts?
>> > One patch moves desktop-file-utils from (gnu packages gnome) to (gnu
>> > packages freedesktop). I suggest we apply this patch to all branches
>> > - since they don't change anything in the build.
>>
>> Adding it to 'master' would be sufficient, no? It will be merged to
>> 'staging' and 'core-updates' in due time.
>
>> I don't see a good reason to move it though, but no strong opinion.
>
> desktop-file-utils is a freedesktop project.
>
> If we don't move it and if KDE used desktop-file-utils (as it should), we'd have KDE depend on Gnome.
Ah, ok. Makes sense.
> If we did move it in all branches, I mean also in wip-installer etc, I think it would prevent any merging problems - since git uses file hashes as commits - and people would not have to take care whether this branch has already moved it or not.
IME, git usually recognizes cherry-picks as the same change, but not
always. I think the problem is that "cherry-pick" is smart, it can adapt
to some fairly complicated context changes unlike e.g. "patch". So, even
if the cherry-pick succeeds, the file and context can be very different.
For example, I recently tested merging a branch with 600+ cherry-picks
back to 'master'. That went mostly-well, but there were some very
difficult conflicts in all files that had changed in the other branch
(and the duplicate branch history did not help).
In short, I think we should prefer merging to cherry-picks whenever
possible. Merging is equally smart, so if cherry-pick works "out of the
box" merge will too. And they definitely do not prevent merging
problems, quite the opposite!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-05-20 23:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 21:01 bug#26988: Add desktop-file-utils to all gtk applications Danny Milosavljevic
2017-05-18 21:07 ` bug#26988: [PATCH] gnu: Move desktop-file-utils to (gnu packages freedesktop) Danny Milosavljevic
2017-05-18 21:19 ` bug#26988: [PATCH] gnu: gtk+-2: Add desktop-file-utils to propagated-inputs Danny Milosavljevic
2017-05-19 23:05 ` bug#26988: Add desktop-file-utils to all gtk applications Marius Bakke
2017-05-20 13:04 ` Danny Milosavljevic
2017-05-20 23:00 ` Marius Bakke [this message]
2017-05-21 2:32 ` Marius Bakke
2017-07-03 15:32 ` 宋文武
2017-07-03 17:08 ` [bug#26988] " Danny Milosavljevic
2017-07-04 11:40 ` 宋文武
2017-06-05 19:22 ` bug#26988: [PATCH v2 0/2] " Danny Milosavljevic
2017-06-05 19:22 ` bug#26988: [PATCH v2 1/2] gnu: Move desktop-file-utils to (gnu packages freedesktop) Danny Milosavljevic
2017-06-15 8:27 ` [bug#26988] " Danny Milosavljevic
2017-06-05 19:22 ` bug#26988: [PATCH v2 2/2] gnu: gtk+-2: Add desktop-file-utils to propagated-inputs Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h90f5e2h.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=26988@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
--cc=iyzsong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.