From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59614) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dS1og-0002MQ-Rr for guix-patches@gnu.org; Mon, 03 Jul 2017 09:55:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dS1oc-0000Zq-Tr for guix-patches@gnu.org; Mon, 03 Jul 2017 09:55:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:46886) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dS1oc-0000Ze-R0 for guix-patches@gnu.org; Mon, 03 Jul 2017 09:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dS1oc-0003M9-IZ for guix-patches@gnu.org; Mon, 03 Jul 2017 09:55:02 -0400 Subject: bug#27542: [PATCH] gnu: gcr: Enable working tests. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Kei Kebreau References: <20170630214326.27709-1-kei@openmailbox.org> <87shie7u9l.fsf@gnu.org> <87podiiqr6.fsf@openmailbox.org> <87shie4n1e.fsf@gnu.org> <87lgo68qjy.fsf@openmailbox.org> <87h8yurn14.fsf@gnu.org> Date: Mon, 03 Jul 2017 09:54:36 -0400 In-Reply-To: <87h8yurn14.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 03 Jul 2017 09:35:03 +0200") Message-ID: <87h8yt8w2r.fsf@openmailbox.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 27542-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Kei Kebreau skribis: > >> ludo@gnu.org (Ludovic Court=C3=A8s) writes: >> >>> Kei Kebreau skribis: >>> >>>> ludo@gnu.org (Ludovic Court=C3=A8s) writes: >>>> >>>>> Hello, >>>>> >>>>> Kei Kebreau skribis: >>>>> >>>>>> * gnu/packages/patches/gcr-disable-failing-tests.patch, >>>>>> gnu/packages/patches/gcr-fix-collection-tests-to-work-with-gpg-21.pa= tch: >>>>>> New files. >>>>>> * gnu/local.mk (dist_patch_DATA): Add patches. >>>>>> * gnu/packages/gnome.scm (gcr)[source]: Use patches. >>>>>> [arguments]: Enable tests. >>>>> >>>>> [...] >>>>> >>>>>> +++ b/gnu/packages/patches/gcr-disable-failing-tests.patch >>>>>> @@ -0,0 +1,127 @@ >>>>>> +This patch removes a group of tests that fail because >>>>>> /var/lib/dbus/machine-id >>>>>> +is not present in the build environment. >>>>> >>>>> We usually work around these with: >>>>> >>>>> (setenv "DBUS_FATAL_WARNINGS" "0") >>>>> >>>>> Is it ineffective here? >>>>> >>>> >>>> That's good to know, but it doesn't seem to work in this case. I get 18 >>>> test failures all from the same group mentioning the missing >>>> 'machine-id' file. >>> >>> Are they really errors and not just warnings (the errors being something >>> else)? >>> >>> Also, could it be that some Makefile or script forcefully sets >>> DBUS_FATAL_WARNINGS to 1, as is the case in =E2=80=98python-dbus=E2=80= =99? >>> >> >> I see no such setting. > > OK. In that case your patch looks like the right thing to me. > > Thank you, and sorry for introducing more delay! > I'd rather be safe than sorry! Thanks for the review. Pushed to master as 85c774808fc13a0adc603784b2358a7c285c4822. > Ludo=E2=80=99. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAllaTJwACgkQ5qXuPBlG eg3loA//Wrfu0cBnxLpDT9ltrbEFtgmaGgT0ahT5WTvRMVEszkc9Q9npecB0wGyR qq3KUYHccRk6yYm++C04C4Lxl+CqTf/KrzD1mejqgVnH5luwgpzgq5ZvGTa5Rpat 2SdbUDiS0SmANAuhVXqnxnwYZ4S71hlCB2qLvaQbsr/tqO5dd98pgmR+E6O1ZYGf Qc7bSw4LyAdN6ULpQoNOqKCWOeaAxILWpBxlRClBH7up4bL2U5fWJFUqxPIBudiR r7b4RLuYQXoBsnDXuOfk9w/rlY3E8wUVLJ+1FPmteqkBVCmQf9MH7zxfCY166nb1 gq80tujWx6DipzNeh98+JrvwLU1NcQfVOZUdn42KOLHuMZJAWhnmrLpCpqP+J9Su ktfSGPnL9pGA28UaVkPsmv3qvRc+tLb2LSrJpy44TlVVzKvlhzRh77tAyfztIWM7 tfDJc2O1xoWdv+6RV76UYqCaoYhyLLI2HvYz4fkrad4npje2E5Wz4U+SZABLITNd vYIU1Kxsao1XS8/kN/ZzHdRSga/lZPvSHWj2yvgtgUp8jZluM7+nmBo44YsLCUYC wtUcHP88/hJ7tvYqxW+/SQRtNCkw+wO5ZmDApiaBwFer/8BF+9hcI5Ij9+N45W6w PmTb5mLr9F+6YxrMZXQseyetGAxzvp0VMbv+TsG/lCBgewgOh9Y= =I6Zg -----END PGP SIGNATURE----- --=-=-=--