[bug#27616] [PATCH] gnu: you-get: Update to 0.4.775.

[bug#27616] [PATCH] gnu: you-get: Update to 0.4.775.

[Feng Shu]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-gnu-you-get-Update-to-0.4.775.patch --]
[-- Type: text/x-patch, Size: 1285 bytes --]

From 395e96f467038358e86d0e3d970055ed7dfce2ba Mon Sep 17 00:00:00 2001
From: Feng Shu <tumashu@163.com>
Date: Sat, 8 Jul 2017 19:43:13 +0800
Subject: [PATCH] gnu: you-get: Update to 0.4.775.

* gnu/packages/video.scm (you-get): Update to 0.4.775.
---
 gnu/packages/video.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index a98a1aa3c..66fce5847 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1238,15 +1238,15 @@ other site that youtube-dl supports.")
 (define-public you-get
   (package
     (name "you-get")
-    (version "0.4.715")
+    (version "0.4.775")
     (source (origin
               (method url-fetch)
               (uri (string-append
-                    "https://github.com/soimort/you-get/releases/download/v"
-                    version "/you-get-" version ".tar.gz"))
+                    "https://github.com/soimort/you-get/archive/v"
+                    version ".tar.gz"))
               (sha256
                (base32
-                "043122hfh56fbbszp1kwd1f65asgyn60j1ijday93hf2dkhvbrnh"))))
+                "1pjjv42c9bysnj8s3c6v0g6b00lr7b21y8ypibnzd6z0jxlsq7sz"))))
     (build-system python-build-system)
     (arguments
      ;; no tests
-- 
2.13.2


[-- Attachment #2: Type: text/plain, Size: 6 bytes --]



-- 

[bug#27616] [PATCH] gnu: you-get: Update to 0.4.775.

[Ben Woodcroft]

[-- Attachment #1: Type: text/plain, Size: 955 bytes --]

Hi Feng, thanks for the patch.


On 08/07/17 21:53, Feng Shu wrote:
> -    (version "0.4.715")
> +    (version "0.4.775")
>       (source (origin
>                 (method url-fetch)
>                 (uri (string-append
> -"https://github.com/soimort/you-get/releases/download/v"
> -                    version "/you-get-" version ".tar.gz"))
> +"https://github.com/soimort/you-get/archive/v"
> +                    version ".tar.gz"))
Here, the downloaded filename is "v0.4.775.tar.gz", which doesn't 
contain "you-get" anymore (we prefer it does so the base directory 
doesn't fill with opaque names, and this is checked by 'guix lint'). We 
usually fix this by adding

(file-name (string-append name "-" version ".tar.gz"))

to the package definition. However, is there some reason why the URL 
scheme should be changed? Alternatively, we could also source this 
package from PyPI given that is recommended on the you-get website. WDYT?

Thanks, ben.

[-- Attachment #2: Type: text/html, Size: 1576 bytes --]

[bug#27616] Update you-get patch, add file-name

[Feng Shu]

[-- Attachment #1: Type: text/plain, Size: 31 bytes --]


Update patch, add file-name



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-you-get-Update-to-0.4.775.patch --]
[-- Type: text/x-patch, Size: 1356 bytes --]

From 544d4b3f8d8f0c5595fba083b6aaf33ebd4d7bda Mon Sep 17 00:00:00 2001
From: Feng Shu <tumashu@163.com>
Date: Sat, 8 Jul 2017 19:43:13 +0800
Subject: [PATCH] gnu: you-get: Update to 0.4.775.

* gnu/packages/video.scm (you-get): Update to 0.4.775.
---
 gnu/packages/video.scm | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index a98a1aa3c..b90534b4c 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1238,15 +1238,16 @@ other site that youtube-dl supports.")
 (define-public you-get
   (package
     (name "you-get")
-    (version "0.4.715")
+    (version "0.4.775")
     (source (origin
               (method url-fetch)
               (uri (string-append
-                    "https://github.com/soimort/you-get/releases/download/v"
-                    version "/you-get-" version ".tar.gz"))
+                    "https://github.com/soimort/you-get/archive/v"
+                    version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
               (sha256
                (base32
-                "043122hfh56fbbszp1kwd1f65asgyn60j1ijday93hf2dkhvbrnh"))))
+                "1pjjv42c9bysnj8s3c6v0g6b00lr7b21y8ypibnzd6z0jxlsq7sz"))))
     (build-system python-build-system)
     (arguments
      ;; no tests
-- 
2.13.2


[-- Attachment #3: Type: text/plain, Size: 7 bytes --]




-- 

bug#27616: Update you-get patch, add file-name

[Ben Woodcroft]

On 08/07/17 23:13, Feng Shu wrote:
> Update patch, add file-name
Thanks, pushed as e2155f58c0b670f495da4a3a0308d5054cf060b0.
ben