From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1do67r-0005AB-3b for guix-patches@gnu.org; Sat, 02 Sep 2017 06:58:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1do67m-0003B8-88 for guix-patches@gnu.org; Sat, 02 Sep 2017 06:58:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:32864) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1do67m-0003Am-4e for guix-patches@gnu.org; Sat, 02 Sep 2017 06:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1do67l-0006hJ-R1 for guix-patches@gnu.org; Sat, 02 Sep 2017 06:58:01 -0400 Subject: [bug#28322] [PATCH] gnu: Add stgit. Resent-Message-ID: From: Marius Bakke In-Reply-To: <87lglyi2a9.fsf@xsteve.at> References: <87lglyi2a9.fsf@xsteve.at> Date: Sat, 02 Sep 2017 12:57:50 +0200 Message-ID: <87h8wll64x.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Stefan =?UTF-8?Q?Reich=C3=B6r?= , 28322@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Stefan Reich=C3=B6r writes: > * gnu/packages/version-control.scm (stgit): New variable. Thanks! [...] =20=20 > +(define-public stgit > + (package > + (name "stgit") > + (version "0.18") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://github.com/ctmarinas/stgit/ar= chive/v" > + version ".tar.gz")) > + (file-name (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "19fk6vw3pgp2a98wpd4j3kyiyll5dy9bi4921wq1mrky0l53mj00"))= )) > + (build-system python-build-system) > + (inputs > + `(("git" ,git))) I noticed this package does not contain any references to git. Check with `guix gc -R $(./pre-inst-env guix build stgit)`. Can you see if it's possible to embed the full path to the `git` executable somehow, so that users don't need to install it separately? Either by embedding the full path in the code directly (preferred), or wrapping the stg executable with git in PATH. It would also be good to run the tests by adding a phase that runs `python t/test.py` according to "tox.ini". Can you try that? Thanks in advance! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmqjq4ACgkQoqBt8qM6 VPqRqAf9FmXBlFY7WchtB/u6+W2M5glJN42uWMj/PaSoOgUE5nRt4Y01D6cNyR64 qw3dJKxTRmSmJgrRFw3/Q0gUAUiE/SMhbzcdALr03AcZDHi5i+7e52DMSCGUIRf7 qsMVz2gvjRu6XWTMClJEXr5uVKtq5r42eJ5LXp/QvhiJ1t8nFV5l9NRZSu1gjmni vr5FKSukMdqecRKPppoDBla+Nmz89pBLcC85bU0gzyZ225zdkMfYd15zhXp4lvEp zSiYqIPVIDQx/NaTm3VgO/rPagBJEo4R4UYjiy64EDCyayT82CUVJsydIyZNAY1q YcfpHv+maGB+Iino/GygXFJY9K8zug== =ibnc -----END PGP SIGNATURE----- --=-=-=--