[bug#28322] [PATCH] gnu: Add stgit.

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1255 bytes --]

Stefan Reichör <stefan@xsteve.at> writes:

> * gnu/packages/version-control.scm (stgit): New variable.

Thanks!

[...]
  
> +(define-public stgit
> +  (package
> +    (name "stgit")
> +    (version "0.18")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/ctmarinas/stgit/archive/v"
> +                                  version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "19fk6vw3pgp2a98wpd4j3kyiyll5dy9bi4921wq1mrky0l53mj00"))))
> +    (build-system python-build-system)
> +    (inputs
> +     `(("git" ,git)))

I noticed this package does not contain any references to git.  Check
with `guix gc -R $(./pre-inst-env guix build stgit)`.

Can you see if it's possible to embed the full path to the `git`
executable somehow, so that users don't need to install it separately?
Either by embedding the full path in the code directly (preferred), or
wrapping the stg executable with git in PATH.

It would also be good to run the tests by adding a phase that runs
`python t/test.py` according to "tox.ini".  Can you try that?

Thanks in advance!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]