From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2gxq-0003j3-TJ for guix-patches@gnu.org; Thu, 12 Oct 2017 13:08:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2gxl-0007L9-QM for guix-patches@gnu.org; Thu, 12 Oct 2017 13:08:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55848) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e2gxl-0007L3-Mq for guix-patches@gnu.org; Thu, 12 Oct 2017 13:08:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e2gxl-0004ww-IT for guix-patches@gnu.org; Thu, 12 Oct 2017 13:08:01 -0400 Subject: [bug#27344] [PATCH v3 7/8] gnu: Add qucs. References: <8760g11j3e.fsf@openmailbox.org> Resent-Message-ID: From: Theodoros Foradis In-reply-to: <87infmccnw.fsf@gnu.org> Date: Thu, 12 Oct 2017 20:07:26 +0300 Message-ID: <87h8v4gur5.fsf@foradis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 27344@debbugs.gnu.org Hello, Ludovic Courtès writes: > Hi, > > Theodoros Foradis skribis: > >> * gnu/packages/engineering.scm (qucs): New variable. > > [...] > >> + (propagated-inputs >> + `(("gcc-toolchain" ,gcc-toolchain-5))) ; for freehdl > > What’s the reason for this? > > Propagated inputs should be used sparsely because they “pollute” user > profiles. Here we’d be forcing a big package, and a specific version of > that, in user profiles, which is not OK. > > Apart from that the patch LGTM though, so if we can remove these two > lines, we can commit. Freehdl is a VHDL to C compiler, so for qucs and qucs-s to be able to do VHDL simulations, there should be a gcc toolchain and libtool in the user environment (libtool should be propagated as well, after the phase removal from the freehdl package). I think it *should* be OK to remove gcc-toolchain from the propagated-inputs, if we provide the user with some kind of message, that they should add a gcc-toolchain and libtool in their environment if they want to do VHDL simulations. Maybe it should be preferable to add a message along those lines in the package descriptions of those 2 packages (qucs and qucs-s)? WDYT? -- Theodoros Foradis