From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59399)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eMCW7-0007S4-Ce
	for guix-patches@gnu.org; Tue, 05 Dec 2017 07:40:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eMCW2-0006ax-Gq
	for guix-patches@gnu.org; Tue, 05 Dec 2017 07:40:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:37835)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eMCW2-0006al-Cw
	for guix-patches@gnu.org; Tue, 05 Dec 2017 07:40:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eMCW2-0006cZ-0s
	for guix-patches@gnu.org; Tue, 05 Dec 2017 07:40:02 -0500
Subject: [bug#29543] [PATCH] gnu: windowmaker: Add '.desktop' file.
Resent-Message-ID: <handler.29543.B29543.151247756925402@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20171203004653.30017-1-kkebreau@posteo.net>
Date: Tue, 05 Dec 2017 13:39:23 +0100
In-Reply-To: <20171203004653.30017-1-kkebreau@posteo.net> (Kei Kebreau's
	message of "Sat, 2 Dec 2017 19:46:53 -0500")
Message-ID: <87h8t5cps4.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Kei Kebreau <kkebreau@posteo.net>
Cc: 29543@debbugs.gnu.org

Kei Kebreau <kkebreau@posteo.net> skribis:

> * gnu/packages/gnustep.scm (windowmaker)[arguments]: Add 'install-xsessio=
n'
> phase.

[...]

> +               (call-with-output-file
> +                   (string-append xsessions "/windowmaker.desktop")
> +                 (lambda (port)
> +                  (format port "~
> +                    [Desktop Entry]~@
> +                    Name=3DWindow Maker~@
> +                    Comment=3D~a~@
> +                    Exec=3D~a/bin/wmaker~@
> +                    Type=3DApplication~%" ,synopsis %output))))

We=E2=80=99ll have to make sure that =E2=80=98synopsis=E2=80=99 does not co=
ntain any newline
character or the =E2=80=98.desktop=E2=80=99 file would have invalid syntax,=
 I suppose.

To be on the safe side perhaps we can do:

  (string-map (match-lambda
                (#\newline #\space)
                (chr chr))
              synopsis)

Apart from that it LGTM, thanks!

Ludo=E2=80=99.