From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQFMg-0007lT-De for guix-patches@gnu.org; Sat, 16 Dec 2017 11:31:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eQFMd-000633-98 for guix-patches@gnu.org; Sat, 16 Dec 2017 11:31:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:57098) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eQFMd-00061x-1y for guix-patches@gnu.org; Sat, 16 Dec 2017 11:31:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eQFMc-0005E4-JH for guix-patches@gnu.org; Sat, 16 Dec 2017 11:31:02 -0500 Subject: [bug#29359] [PATCH 21/31] gnu: Add java-xmlpull2. Resent-Message-ID: References: <20171119175805.902-1-julien@lepiller.eu> <20171119175805.902-21-julien@lepiller.eu> From: Ricardo Wurmus In-reply-to: <20171119175805.902-21-julien@lepiller.eu> Date: Sat, 16 Dec 2017 17:30:05 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID: <87h8sqoctu.fsf@elephly.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller Cc: 29359@debbugs.gnu.org Hi Julien, > * gnu/packages/java.scm (java-xmlpull2): New variable. Please move this package to xml.scm. [=E2=80=A6] > + (modify-phases %standard-phases > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((out (string-append (assoc-ref outputs "out") "/share= /java"))) > + (mkdir-p out) > + (copy-file "build/lib/PullParser-standard-2.1.10.jar" > + (string-append out "/xmlpull2-standard.jar")) > + (copy-file "build/lib/PullParser-2.1.10.jar" > + (string-append out "/xmlpull2.jar"))) > + #t))))) Could you use the =E2=80=9Cinstall-jars=E2=80=9D procedure instead of this = custom phase? > + (home-page "http://www.extreme.indiana.edu/xgws/xsoap/xpp/") > + (synopsis "Streaming pull XML parser") > + (description "Xml Pull Parser (in short XPP) is a streaming pull > XML Please capitalize the first =E2=80=9CXml=E2=80=9D. > +parser and should be used when there is a need to process quickly and > +efficiently all input elements (for example in SOAP processors).") > + (license license:public-domain))) The license does not seem to be correct. This is the license: http://www.extreme.indiana.edu/xgws/xsoap/xpp/download/PullParser2/LICENS= E.txt It looks like a variant of the BSD-4 license, so non-copyleft would be appropriate here. See also the Debian copyright file: http://metadata.ftp-master.debian.org/changelogs/main/libx/libxpp2-java/l= ibxpp2-java_2.1.10-7_copyright -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net