From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37107)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1esEp3-0007tc-Jc
	for guix-patches@gnu.org; Sat, 03 Mar 2018 16:36:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1esEp0-0006zz-Em
	for guix-patches@gnu.org; Sat, 03 Mar 2018 16:36:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:35245)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1esEp0-0006zu-Az
	for guix-patches@gnu.org; Sat, 03 Mar 2018 16:36:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1esEp0-00064C-4d
	for guix-patches@gnu.org; Sat, 03 Mar 2018 16:36:02 -0500
Subject: [bug#30596] [PATCH 5/6] gnu: Add cmake@3.11.
Resent-Message-ID: <handler.30596.B30596.152011293423284@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180224190349.8155-1-mbakke@fastmail.com>
	<20180224190349.8155-5-mbakke@fastmail.com>
Date: Sat, 03 Mar 2018 22:35:26 +0100
In-Reply-To: <20180224190349.8155-5-mbakke@fastmail.com> (Marius Bakke's
	message of "Sat, 24 Feb 2018 20:03:48 +0100")
Message-ID: <87h8pw971d.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 30596@debbugs.gnu.org

Marius Bakke <mbakke@fastmail.com> skribis:

> * gnu/packages/patches/cmake-3.11-pthread-fix.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Register it.
> * gnu/packages/cmake.scm (cmake-3.11): New public variable.

[...]

> +;; Recent Ceph requires Boost 1.66, which in turn requires CMake 3.11 for
> +;; its updated "FindBoost.cmake" facility.
> +(define-public cmake-3.11

The actual upgrade is for =E2=80=98core-updates=E2=80=99 as well I guess?

> +    (arguments
> +     `(,@(substitute-keyword-arguments (package-arguments cmake)
> +           ((#:phases phases)

Or simply:

  (arguments
    (substitute-keyword-arguments =E2=80=A6))

Otherwise LGTM, thanks!

Ludo=E2=80=99.